Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Return silently when memory hint/prefetch unsupported for alloc type 

Change-Id: I26324d47358ebcfe2d5af9e4fb22448e7e453d15
Signed-off-by: Raiyan Latif <raiyan.latif@intel.com>
This commit is contained in:
Raiyan Latif 2020-04-30 13:37:34 -07:00 committed by sys_ocldev
parent f0c7f5f5de
commit 031ea89465
2 changed files with 58 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
level_zero/core/source/cmdlist/cmdlist_hw.inl
View File

@ -531,14 +531,8 @@ ze_result_t CommandListCoreFamily<gfxCoreFamily>::appendMemAdvise(ze_device_hand
auto allocData = device->getDriverHandle()->getSvmAllocsManager()->getSVMAllocs()->get(ptr);
if (allocData) {
if (allocData->memoryType == InternalMemoryType::SHARED_UNIFIED_MEMORY) {
return ZE_RESULT_SUCCESS;
} else {
DEBUG_BREAK_IF(true);
return ZE_RESULT_ERROR_UNKNOWN;
}
}
DEBUG_BREAK_IF(true);
return ZE_RESULT_ERROR_UNKNOWN;
}
@ -926,14 +920,8 @@ ze_result_t CommandListCoreFamily<gfxCoreFamily>::appendMemoryPrefetch(const voi
size_t count) {
auto allocData = device->getDriverHandle()->getSvmAllocsManager()->getSVMAllocs()->get(ptr);
if (allocData) {
if (allocData->memoryType == InternalMemoryType::SHARED_UNIFIED_MEMORY) {
return ZE_RESULT_SUCCESS;
} else {
DEBUG_BREAK_IF(true);
return ZE_RESULT_ERROR_UNKNOWN;
}
}
DEBUG_BREAK_IF(true);
return ZE_RESULT_ERROR_UNKNOWN;
}

58
level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist.cpp
View File

@ -69,6 +69,64 @@ TEST_F(CommandListCreate, givenRegularCommandListThenDefaultNumIddPerBlockIsUsed
EXPECT_EQ(defaultNumIdds, commandList->commandContainer.getNumIddPerBlock());
}
TEST_F(CommandListCreate, givenNonExistingPtrThenAppendMemAdviseReturnsError) {
std::unique_ptr<L0::CommandList> commandList(CommandList::create(productFamily, device, false));
ASSERT_NE(nullptr, commandList);
auto res = commandList->appendMemAdvise(device, nullptr, 0, ZE_MEMORY_ADVICE_SET_READ_MOSTLY);
EXPECT_EQ(ZE_RESULT_ERROR_UNKNOWN, res);
}
TEST_F(CommandListCreate, givenNonExistingPtrThenAppendMemoryPrefetchReturnsError) {
std::unique_ptr<L0::CommandList> commandList(CommandList::create(productFamily, device, false));
ASSERT_NE(nullptr, commandList);
auto res = commandList->appendMemoryPrefetch(nullptr, 0);
EXPECT_EQ(ZE_RESULT_ERROR_UNKNOWN, res);
}
TEST_F(CommandListCreate, givenValidPtrThenAppendMemAdviseReturnsSuccess) {
size_t size = 10;
size_t alignment = 1u;
void *ptr = nullptr;
auto res = driverHandle->allocDeviceMem(device->toHandle(),
ZE_DEVICE_MEM_ALLOC_FLAG_DEFAULT,
size, alignment, &ptr);
EXPECT_EQ(ZE_RESULT_SUCCESS, res);
EXPECT_NE(nullptr, ptr);
std::unique_ptr<L0::CommandList> commandList(CommandList::create(productFamily, device, false));
ASSERT_NE(nullptr, commandList);
res = commandList->appendMemAdvise(device, ptr, size, ZE_MEMORY_ADVICE_SET_READ_MOSTLY);
EXPECT_EQ(ZE_RESULT_SUCCESS, res);
res = driverHandle->freeMem(ptr);
ASSERT_EQ(res, ZE_RESULT_SUCCESS);
}
TEST_F(CommandListCreate, givenValidPtrThenAppendMemoryPrefetchReturnsSuccess) {
size_t size = 10;
size_t alignment = 1u;
void *ptr = nullptr;
auto res = driverHandle->allocDeviceMem(device->toHandle(),
ZE_DEVICE_MEM_ALLOC_FLAG_DEFAULT,
size, alignment, &ptr);
EXPECT_EQ(ZE_RESULT_SUCCESS, res);
EXPECT_NE(nullptr, ptr);
std::unique_ptr<L0::CommandList> commandList(CommandList::create(productFamily, device, false));
ASSERT_NE(nullptr, commandList);
res = commandList->appendMemoryPrefetch(ptr, size);
EXPECT_EQ(ZE_RESULT_SUCCESS, res);
res = driverHandle->freeMem(ptr);
ASSERT_EQ(res, ZE_RESULT_SUCCESS);
}
TEST_F(CommandListCreate, givenImmediateCommandListThenCustomNumIddPerBlockUsed) {
const ze_command_queue_desc_t desc = {
ZE_COMMAND_QUEUE_DESC_VERSION_CURRENT,