Media/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-09-15 13:01:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove dcFlush parameter from finish call

Browse Source 
Change-Id: Ifc808822399a100745a9d81bb5f6e45903a895fa
Signed-off-by: Dunajski, Bartosz <bartosz.dunajski@intel.com>
This commit is contained in:
Dunajski, Bartosz
2019-09-13 10:11:17 +02:00
committed by sys_ocldev
parent c0c6a46ece
commit 0337b58ee4
33 changed files with 56 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
unit_tests/command_queue/command_queue_hw_tests.cpp
View File

@ -283,7 +283,7 @@ HWTEST_F(CommandQueueHwTest, GivenNonEmptyQueueOnBlockingMapBufferWillWaitForPre
: CommandQueueHw<FamilyType>(context, device, 0) {
finishWasCalled = false;
}
cl_int finish(bool dcFlush) override {
cl_int finish() override {
finishWasCalled = true;
return 0;
}

2
unit_tests/command_queue/command_queue_tests.cpp
View File

@ -790,7 +790,7 @@ HWTEST_F(WaitForQueueCompletionTests, givenBlockingCallAndBlockedQueueWhenEnqueu
HWTEST_F(WaitForQueueCompletionTests, whenFinishIsCalledThenCallWaitWithoutQuickKmdSleepRequest) {
std::unique_ptr<MyCmdQueue<FamilyType>> cmdQ(new MyCmdQueue<FamilyType>(context.get(), device.get()));
cmdQ->finish(false);
cmdQ->finish();
EXPECT_EQ(1u, cmdQ->waitUntilCompleteCounter);
EXPECT_FALSE(cmdQ->requestedUseQuickKmdSleep);
}

4
unit_tests/command_queue/enqueue_kernel_1_tests.cpp
View File

@ -617,7 +617,7 @@ HWTEST_F(EnqueueKernelTest, givenCsrInBatchingModeWhenFinishIsCalledThenBatchesS
pCmdQ->enqueueKernel(mockKernel.mockKernel, 1, nullptr, gws, nullptr, 0, nullptr, nullptr);
pCmdQ->enqueueKernel(mockKernel.mockKernel, 1, nullptr, gws, nullptr, 0, nullptr, nullptr);
pCmdQ->finish(false);
pCmdQ->finish();
EXPECT_TRUE(mockedSubmissionsAggregator->peekCmdBufferList().peekIsEmpty());
EXPECT_EQ(1, mockCsr->flushCalledCount);
@ -637,7 +637,7 @@ HWTEST_F(EnqueueKernelTest, givenCsrInBatchingModeWhenThressEnqueueKernelsAreCal
pCmdQ->enqueueKernel(mockKernel.mockKernel, 1, nullptr, gws, nullptr, 0, nullptr, nullptr);
pCmdQ->enqueueKernel(mockKernel.mockKernel, 1, nullptr, gws, nullptr, 0, nullptr, nullptr);
pCmdQ->finish(false);
pCmdQ->finish();
EXPECT_TRUE(mockedSubmissionsAggregator->peekCmdBufferList().peekIsEmpty());
EXPECT_EQ(1, mockCsr->flushCalledCount);

6
unit_tests/command_queue/enqueue_kernel_event_tests.cpp
View File

@ -88,7 +88,7 @@ TEST_F(EventTests, eventWaitShouldntSendPC) {
// no more tasks after WFE, no need to write PC
EXPECT_EQ(pEvent->taskLevel + 1, csr.peekTaskLevel());
pCmdQ->finish(false);
pCmdQ->finish();
// Check CL_EVENT_COMMAND_TYPE
{
@ -132,7 +132,7 @@ TEST_F(EventTests, waitForArray) {
EXPECT_EQ(CL_SUCCESS, retVal);
EXPECT_EQ(pEvent1->taskLevel + 1, csr.peekTaskLevel());
pCmdQ->finish(false);
pCmdQ->finish();
EXPECT_EQ(pEvent1->taskLevel + 1, csr.peekTaskLevel());
// Check CL_EVENT_COMMAND_TYPE
{
@ -172,7 +172,7 @@ TEST_F(EventTests, event_NDR_Wait_NDR_Finish) {
ASSERT_EQ(CL_SUCCESS, retVal);
EXPECT_EQ(pEvent->taskLevel + 2, csr.peekTaskLevel());
pCmdQ->finish(false);
pCmdQ->finish();
EXPECT_EQ(pEvent->taskLevel + 2, csr.peekTaskLevel());
// Check CL_EVENT_COMMAND_TYPE

2
unit_tests/command_queue/enqueue_kernel_mt_tests.cpp
View File

@ -59,7 +59,7 @@ HWTEST_F(EnqueueKernelTest, givenCsrInBatchingModeWhenFinishIsCalledThenBatchesS
thread.join();
}
pCmdQ->finish(false);
pCmdQ->finish();
EXPECT_GE(mockCsr->flushCalledCount, 1);

2
unit_tests/command_queue/enqueue_read_buffer_rect_tests.cpp
View File

@ -548,7 +548,7 @@ HWTEST_F(EnqueueReadWriteBufferRectDispatch, givenOffsetResultingInMisalignedPtr
ASSERT_NE(0u, cmdQ->lastEnqueuedKernels.size());
Kernel *kernel = cmdQ->lastEnqueuedKernels[0];
cmdQ->finish(true);
cmdQ->finish();
parseCommands<FamilyType>(*cmdQ);

2
unit_tests/command_queue/enqueue_thread_tests.cpp
View File

@ -423,6 +423,6 @@ HWTEST_F(EnqueueThreading, finish) {
auto csr = (CommandStreamReceiverMock<FamilyType> *)&this->pCmdQ->getGpgpuCommandStreamReceiver();
csr->expectedToFreeCount = 0u;
pCmdQ->finish(false);
pCmdQ->finish();
}
} // namespace ULT

2
unit_tests/command_queue/enqueue_write_buffer_rect_tests.cpp
View File

@ -545,7 +545,7 @@ HWTEST_F(EnqueueReadWriteBufferRectDispatch, givenOffsetResultingInMisalignedPtr
ASSERT_NE(0u, cmdQ->lastEnqueuedKernels.size());
Kernel *kernel = cmdQ->lastEnqueuedKernels[0];
cmdQ->finish(true);
cmdQ->finish();
parseCommands<FamilyType>(*cmdQ);

6
unit_tests/command_queue/finish_tests.cpp
View File

@ -55,7 +55,7 @@ HWTEST_F(FinishTest, ShouldntAddPipeControl_If_CS_greater_than_CQ) {
commandStreamReceiver.taskLevel = originalCSRLevel; // Must be greater than or equal to HW
pCmdQ->taskLevel = originalCQLevel;
auto retVal = pCmdQ->finish(false);
auto retVal = pCmdQ->finish();
ASSERT_EQ(CL_SUCCESS, retVal);
// Don't need to artificially execute PIPE_CONTROL.
@ -77,7 +77,7 @@ HWTEST_F(FinishTest, ShouldntAddPipeControl_If_CS_greater_than_CQ) {
HWTEST_F(FinishTest, doesntAddAPipecontrolToCQCommandStream) {
typedef typename FamilyType::PIPE_CONTROL PIPE_CONTROL;
auto retVal = pCmdQ->finish(false);
auto retVal = pCmdQ->finish();
ASSERT_EQ(CL_SUCCESS, retVal);
// Check for PIPE_CONTROL
@ -89,7 +89,7 @@ HWTEST_F(FinishTest, givenFreshQueueWhenFinishIsCalledThenCommandStreamIsNotAllo
MockContext contextWithMockCmdQ(pDevice, true);
MockCommandQueueHw<FamilyType> cmdQ(&contextWithMockCmdQ, pDevice, 0);
auto retVal = cmdQ.finish(false);
auto retVal = cmdQ.finish();
ASSERT_EQ(CL_SUCCESS, retVal);
EXPECT_EQ(nullptr, cmdQ.peekCommandStream());

2
unit_tests/command_queue/get_size_required_tests.cpp
View File

@ -47,7 +47,7 @@ HWTEST_F(GetSizeRequiredTest, finish) {
auto &commandStream = pCmdQ->getCS(1024);
auto usedBeforeCS = commandStream.getUsed();
auto retVal = pCmdQ->finish(false);
auto retVal = pCmdQ->finish();
EXPECT_EQ(CL_SUCCESS, retVal);
EXPECT_EQ(0u, commandStream.getUsed() - usedBeforeCS);

2
unit_tests/command_queue/oom_tests.cpp
View File

@ -73,7 +73,7 @@ HWTEST_P(OOMCommandQueueTest, finish) {
auto usedBeforeCS = commandStream.getUsed();
auto usedBeforeISH = indirectHeap.getUsed();
auto retVal = pCmdQ->finish(false);
auto retVal = pCmdQ->finish();
auto usedAfterCS = commandStream.getUsed();
auto usedAfterISH = indirectHeap.getUsed();