Media/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-09-15 13:01:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove not needed HwHelper functions

Browse Source 
Related-To: NEO-6853
Signed-off-by: Kamil Kopryk <kamil.kopryk@intel.com>

Remove not needed HwHelper functions
- getBindingTableStateSurfaceStatePointer
- getBindingTableStateSize
- getBindingTableStateAlignement
This commit is contained in:
Kamil Kopryk
2022-11-07 20:33:59 +00:00
committed by Compute-Runtime-Automation
parent b579bf645b
commit 0b02e7a48b
2 changed files with 0 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
opencl/test/unit_test/helpers/hw_helper_tests.cpp
View File

@ -141,32 +141,6 @@ HWTEST_F(HwHelperTest, WhenSettingRenderSurfaceStateForBufferThenL1CachePolicyIs
alignedFree(stateBuffer); alignedFree(stateBuffer);
} }
HWTEST_F(HwHelperTest, WhenGettingBindingTableStateSurfaceStatePointerThenCorrectPointerIsReturned) {
using BINDING_TABLE_STATE = typename FamilyType::BINDING_TABLE_STATE;
BINDING_TABLE_STATE bindingTableState[4];
bindingTableState[2].getRawData(0) = 0x00123456;
auto &helper = HwHelper::get(renderCoreFamily);
auto pointer = helper.getBindingTableStateSurfaceStatePointer(bindingTableState, 2);
EXPECT_EQ(0x00123456u, pointer);
}
HWTEST_F(HwHelperTest, WhenGettingBindingTableStateSizeThenCorrectSizeIsReturned) {
using BINDING_TABLE_STATE = typename FamilyType::BINDING_TABLE_STATE;
auto &helper = HwHelper::get(renderCoreFamily);
auto pointer = helper.getBindingTableStateSize();
EXPECT_EQ(sizeof(BINDING_TABLE_STATE), pointer);
}
TEST_F(HwHelperTest, WhenGettingBindingTableStateAlignementThenCorrectSizeIsReturned) {
auto &helper = HwHelper::get(renderCoreFamily);
EXPECT_NE(0u, helper.getBindingTableStateAlignement());
}
HWTEST_F(HwHelperTest, WhenGettingInterfaceDescriptorDataSizeThenCorrectSizeIsReturned) { HWTEST_F(HwHelperTest, WhenGettingInterfaceDescriptorDataSizeThenCorrectSizeIsReturned) {
using INTERFACE_DESCRIPTOR_DATA = typename FamilyType::INTERFACE_DESCRIPTOR_DATA; using INTERFACE_DESCRIPTOR_DATA = typename FamilyType::INTERFACE_DESCRIPTOR_DATA;
auto &helper = HwHelper::get(renderCoreFamily); auto &helper = HwHelper::get(renderCoreFamily);

20
shared/source/helpers/hw_helper.h
View File

@ -39,9 +39,6 @@ struct PipeControlArgs;
class HwHelper { class HwHelper {
public: public:
static HwHelper &get(GFXCORE_FAMILY gfxCore); static HwHelper &get(GFXCORE_FAMILY gfxCore);
virtual uint32_t getBindingTableStateSurfaceStatePointer(const void *pBindingTable, uint32_t index) = 0;
virtual size_t getBindingTableStateSize() const = 0;
virtual uint32_t getBindingTableStateAlignement() const = 0;
virtual size_t getInterfaceDescriptorDataSize() const = 0; virtual size_t getInterfaceDescriptorDataSize() const = 0;
virtual size_t getMaxBarrierRegisterPerSlice() const = 0; virtual size_t getMaxBarrierRegisterPerSlice() const = 0;
virtual size_t getPaddingForISAAllocation() const = 0; virtual size_t getPaddingForISAAllocation() const = 0;
@ -175,23 +172,6 @@ class HwHelperHw : public HwHelper {
return hwHelper; return hwHelper;
} }
uint32_t getBindingTableStateSurfaceStatePointer(const void *pBindingTable, uint32_t index) override {
using BINDING_TABLE_STATE = typename GfxFamily::BINDING_TABLE_STATE;
const BINDING_TABLE_STATE *bindingTableState = static_cast<const BINDING_TABLE_STATE *>(pBindingTable);
return bindingTableState[index].getRawData(0);
}
size_t getBindingTableStateSize() const override {
using BINDING_TABLE_STATE = typename GfxFamily::BINDING_TABLE_STATE;
return sizeof(BINDING_TABLE_STATE);
}
uint32_t getBindingTableStateAlignement() const override {
using BINDING_TABLE_STATE = typename GfxFamily::BINDING_TABLE_STATE;
return BINDING_TABLE_STATE::SURFACESTATEPOINTER_ALIGN_SIZE;
}
size_t getInterfaceDescriptorDataSize() const override { size_t getInterfaceDescriptorDataSize() const override {
using INTERFACE_DESCRIPTOR_DATA = typename GfxFamily::INTERFACE_DESCRIPTOR_DATA; using INTERFACE_DESCRIPTOR_DATA = typename GfxFamily::INTERFACE_DESCRIPTOR_DATA;
return sizeof(INTERFACE_DESCRIPTOR_DATA); return sizeof(INTERFACE_DESCRIPTOR_DATA);