Media/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-09-15 13:01:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused subgroupKernelInfoArray

Browse Source 
Signed-off-by: Katarzyna Cencelewska <katarzyna.cencelewska@intel.com>
This commit is contained in:
Katarzyna Cencelewska
2022-01-19 10:48:17 +00:00
committed by Compute-Runtime-Automation
parent 5cd76aef6a
commit 11fe5f33f5
5 changed files with 1 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
opencl/source/program/process_device_binary.cpp
View File

@ -234,10 +234,6 @@ cl_int Program::processProgramInfo(ProgramInfo &src, const ClDevice &clDevice) {
return retVal;
}
if (kernelInfo->requiresSubgroupIndependentForwardProgress()) {
buildInfos[rootDeviceIndex].subgroupKernelInfoArray.push_back(kernelInfo);
}
kernelInfo->apply(deviceInfoConstants);
}

1
opencl/source/program/program.h
View File

@ -331,7 +331,6 @@ class Program : public BaseObject<_cl_program> {
struct BuildInfo : public NonCopyableClass {
std::vector<KernelInfo *> kernelInfoArray;
std::vector<KernelInfo *> subgroupKernelInfoArray;
GraphicsAllocation *constantSurface = nullptr;
GraphicsAllocation *globalSurface = nullptr;
GraphicsAllocation *exportedFunctionsSurface = nullptr;

1
opencl/test/unit_test/kernel/kernel_tests.cpp
View File

@ -2737,6 +2737,7 @@ TEST(KernelTest, givenKernelWhenSettingAdditinalKernelExecInfoThenCorrectValueIs
UltClDeviceFactory deviceFactory{1, 0};
MockKernelWithInternals mockKernelWithInternals{*deviceFactory.rootDevices[0]};
mockKernelWithInternals.kernelInfo.kernelDescriptor.kernelAttributes.flags.requiresSubgroupIndependentForwardProgress = true;
EXPECT_TRUE(mockKernelWithInternals.kernelInfo.requiresSubgroupIndependentForwardProgress());
auto &mockKernel = *mockKernelWithInternals.mockKernel;

4
opencl/test/unit_test/mocks/mock_program.h
View File

@ -92,10 +92,6 @@ class MockProgram : public Program {
void addKernelInfo(KernelInfo *inInfo, uint32_t rootDeviceIndex) {
buildInfos[rootDeviceIndex].kernelInfoArray.push_back(inInfo);
}
std::vector<KernelInfo *> &getSubgroupKernelInfoArray(uint32_t rootDeviceIndex) {
return buildInfos[rootDeviceIndex].subgroupKernelInfoArray;
}
void setContext(Context *context) {
this->context = context;
contextSet = true;

28
opencl/test/unit_test/program/kernel_data.cpp
View File

@ -326,34 +326,6 @@ TEST_F(KernelDataTest, GivenExecutionEnvironmentCompiledForGreaterThan4gbBuffers
EXPECT_EQ(KernelDescriptor::Stateless, pKernelInfo->kernelDescriptor.kernelAttributes.bufferAddressingMode);
}
TEST_F(KernelDataTest, GivenExecutionEnvironmentDoesntRequireSubgroupIndependentForwardProgressWhenBuildingThenProgramIsCorrect) {
iOpenCL::SPatchExecutionEnvironment executionEnvironment = {};
executionEnvironment.Token = PATCH_TOKEN_EXECUTION_ENVIRONMENT;
executionEnvironment.Size = sizeof(SPatchExecutionEnvironment);
executionEnvironment.SubgroupIndependentForwardProgressRequired = false;
pPatchList = &executionEnvironment;
patchListSize = executionEnvironment.Size;
buildAndDecode();
EXPECT_EQ_VAL(0u, program->getSubgroupKernelInfoArray(rootDeviceIndex).size());
}
TEST_F(KernelDataTest, GivenExecutionEnvironmentRequiresSubgroupIndependentForwardProgressWhenBuildingThenProgramIsCorrect) {
iOpenCL::SPatchExecutionEnvironment executionEnvironment = {};
executionEnvironment.Token = PATCH_TOKEN_EXECUTION_ENVIRONMENT;
executionEnvironment.Size = sizeof(SPatchExecutionEnvironment);
executionEnvironment.SubgroupIndependentForwardProgressRequired = true;
pPatchList = &executionEnvironment;
patchListSize = executionEnvironment.Size;
buildAndDecode();
EXPECT_EQ_VAL(1u, program->getSubgroupKernelInfoArray(rootDeviceIndex).size());
}
TEST_F(KernelDataTest, WhenDecodingExecutionEnvironmentTokenThenWalkOrderIsForcedToXMajor) {
iOpenCL::SPatchExecutionEnvironment executionEnvironment = {};
executionEnvironment.Token = PATCH_TOKEN_EXECUTION_ENVIRONMENT;