fix: silence new issues with clang-tidy 18 on windows

Signed-off-by: Pawel Cieslak <pawel.cieslak@intel.com>
This commit is contained in:
Pawel Cieslak 2025-02-11 12:41:04 +00:00 committed by Compute-Runtime-Automation
parent 4b0473718e
commit 184378e4df
6 changed files with 34 additions and 30 deletions

View File

@ -1,5 +1,5 @@
/*
* Copyright (C) 2018-2022 Intel Corporation
* Copyright (C) 2018-2025 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@ -234,12 +234,12 @@ void EventsTracker::notifyCreation(Event *eventToTrack) {
dump();
auto trackedE = new TrackedEvent{eventToTrack, eventId++};
trackedEvents.pushFrontOne(*trackedE);
}
} // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks), NEO-14033
void EventsTracker::notifyDestruction(Event *eventToDestroy) {
auto trackedE = new TrackedEvent{eventToDestroy, -(eventId++)};
trackedEvents.pushFrontOne(*trackedE);
dump();
dump(); // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks), NEO-14033
}
void EventsTracker::notifyTransitionedExecutionStatus() {

View File

@ -1,5 +1,5 @@
/*
* Copyright (C) 2018-2024 Intel Corporation
* Copyright (C) 2018-2025 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@ -247,7 +247,7 @@ TEST_F(D3D9Tests, WhenCreatingSurfaceIntelThenImagePropertiesAreSetCorrectly) {
}
TEST_F(D3D9Tests, givenD3DHandleWhenCreatingSharedSurfaceThenAllocationTypeImageIsSet) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = reinterpret_cast<HANDLE>(1);
mockSharingFcns->getTexture2dDescSetParams = true;
@ -263,7 +263,7 @@ TEST_F(D3D9Tests, givenD3DHandleWhenCreatingSharedSurfaceThenAllocationTypeImage
}
TEST_F(D3D9Tests, givenUPlaneWhenCreateSurfaceThenChangeWidthHeightAndPitch) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)1;
mockSharingFcns->getTexture2dDescSetParams = true;
@ -280,7 +280,7 @@ TEST_F(D3D9Tests, givenUPlaneWhenCreateSurfaceThenChangeWidthHeightAndPitch) {
}
TEST_F(D3D9Tests, givenVPlaneWhenCreateSurfaceThenChangeWidthHeightAndPitch) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)1;
mockSharingFcns->getTexture2dDescSetParams = true;
@ -297,7 +297,7 @@ TEST_F(D3D9Tests, givenVPlaneWhenCreateSurfaceThenChangeWidthHeightAndPitch) {
}
TEST_F(D3D9Tests, givenUVPlaneWhenCreateSurfaceThenChangeWidthHeightAndPitch) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('N', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('N', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)1;
mockSharingFcns->getTexture2dDescSetParams = true;
@ -314,7 +314,7 @@ TEST_F(D3D9Tests, givenUVPlaneWhenCreateSurfaceThenChangeWidthHeightAndPitch) {
}
TEST_F(D3D9Tests, givenYPlaneWhenCreateSurfaceThenDontChangeWidthHeightAndPitch) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('N', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('N', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)1;
mockSharingFcns->getTexture2dDescSetParams = true;
@ -331,7 +331,7 @@ TEST_F(D3D9Tests, givenYPlaneWhenCreateSurfaceThenDontChangeWidthHeightAndPitch)
}
TEST_F(D3D9Tests, givenUPlaneWhenCreateNonSharedSurfaceThenChangeWidthHeightAndPitch) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)0;
mockSharingFcns->getTexture2dDescSetParams = true;
@ -348,7 +348,7 @@ TEST_F(D3D9Tests, givenUPlaneWhenCreateNonSharedSurfaceThenChangeWidthHeightAndP
}
TEST_F(D3D9Tests, givenVPlaneWhenCreateNonSharedSurfaceThenChangeWidthHeightAndPitch) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)0;
mockSharingFcns->getTexture2dDescSetParams = true;
@ -365,7 +365,7 @@ TEST_F(D3D9Tests, givenVPlaneWhenCreateNonSharedSurfaceThenChangeWidthHeightAndP
}
TEST_F(D3D9Tests, givenUVPlaneWhenCreateNonSharedSurfaceThenChangeWidthHeightAndPitch) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('N', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('N', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)0;
mockSharingFcns->getTexture2dDescSetParams = true;
@ -382,7 +382,7 @@ TEST_F(D3D9Tests, givenUVPlaneWhenCreateNonSharedSurfaceThenChangeWidthHeightAnd
}
TEST_F(D3D9Tests, givenYPlaneWhenCreateNonSharedSurfaceThenDontChangeWidthHeightAndPitch) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('N', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('N', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)0;
mockSharingFcns->getTexture2dDescSetParams = true;
@ -400,7 +400,7 @@ TEST_F(D3D9Tests, givenYPlaneWhenCreateNonSharedSurfaceThenDontChangeWidthHeight
TEST_F(D3D9Tests, givenNV12FormatAndInvalidPlaneWhenSurfaceIsCreatedThenReturnError) {
cl_int retVal = CL_SUCCESS;
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('N', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('N', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)0;
mockSharingFcns->getTexture2dDescSetParams = true;
@ -413,7 +413,7 @@ TEST_F(D3D9Tests, givenNV12FormatAndInvalidPlaneWhenSurfaceIsCreatedThenReturnEr
TEST_F(D3D9Tests, givenYV12FormatAndInvalidPlaneWhenSurfaceIsCreatedThenReturnError) {
cl_int retVal = CL_SUCCESS;
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)0;
mockSharingFcns->getTexture2dDescSetParams = true;
@ -473,7 +473,7 @@ TEST_F(D3D9Tests, givenAlreadyUsedSurfaceWhenSurfaceIsCreatedThenReturnError) {
TEST_F(D3D9Tests, givenNotSupportedFormatWhenSurfaceIsCreatedThenReturnError) {
cl_int retVal = CL_SUCCESS;
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('I', '4', '2', '0');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('I', '4', '2', '0'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)0;
mockSharingFcns->getTexture2dDescSetParams = true;
@ -485,7 +485,7 @@ TEST_F(D3D9Tests, givenNotSupportedFormatWhenSurfaceIsCreatedThenReturnError) {
}
TEST_F(D3D9Tests, GivenMediaSurfaceInfoKhrWhenGetMemObjInfoThenCorrectInfoIsReturned) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
cl_dx9_media_adapter_type_khr expectedAdapterType = 5;
cl_uint expectedPlane = 2;
cl_dx9_surface_info_khr getSurfaceInfo = {};
@ -508,7 +508,7 @@ TEST_F(D3D9Tests, GivenMediaSurfaceInfoKhrWhenGetMemObjInfoThenCorrectInfoIsRetu
}
TEST_F(D3D9Tests, GivenResourceIntelWhenGetMemObjInfoThenCorrectInfoIsReturned) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
cl_dx9_media_adapter_type_khr expectedAdapterType = 5;
cl_uint expectedPlane = 2;
cl_dx9_surface_info_khr getSurfaceInfo = {};
@ -531,7 +531,7 @@ TEST_F(D3D9Tests, GivenResourceIntelWhenGetMemObjInfoThenCorrectInfoIsReturned)
}
TEST_F(D3D9Tests, GivenSharedHandleIntelWhenGetMemObjInfoThenCorrectInfoIsReturned) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
cl_dx9_media_adapter_type_khr expectedAdapterType = 5;
cl_uint expectedPlane = 2;
cl_dx9_surface_info_khr getSurfaceInfo = {};
@ -553,7 +553,7 @@ TEST_F(D3D9Tests, GivenSharedHandleIntelWhenGetMemObjInfoThenCorrectInfoIsReturn
}
TEST_F(D3D9Tests, GivenMediaAdapterTypeKhrWhenGetMemObjInfoThenCorrectInfoIsReturned) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
cl_dx9_media_adapter_type_khr adapterType = 0;
cl_dx9_media_adapter_type_khr expectedAdapterType = 5;
cl_uint expectedPlane = 2;
@ -575,7 +575,7 @@ TEST_F(D3D9Tests, GivenMediaAdapterTypeKhrWhenGetMemObjInfoThenCorrectInfoIsRetu
}
TEST_F(D3D9Tests, GivenMediaPlaneKhrWhenGetMemObjInfoThenCorrectInfoIsReturned) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
cl_dx9_media_adapter_type_khr expectedAdapterType = 5;
cl_uint plane = 0;
cl_uint expectedPlane = 2;
@ -597,7 +597,7 @@ TEST_F(D3D9Tests, GivenMediaPlaneKhrWhenGetMemObjInfoThenCorrectInfoIsReturned)
}
TEST_F(D3D9Tests, GivenPlaneIntelWhenGetMemObjInfoThenCorrectInfoIsReturned) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
cl_dx9_media_adapter_type_khr expectedAdapterType = 5;
cl_uint plane = 0;
cl_uint expectedPlane = 2;
@ -1089,7 +1089,7 @@ TEST_F(D3D9Tests, givenInvalidContextWhenImageIsCreatedThenErrorIsReturned) {
}
TEST_F(D3D9Tests, givenTheSameResourceAndPlaneWhenSurfaceIsCreatedThenReturnError) {
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2');
mockSharingFcns->mockTexture2dDesc.Format = (D3DFORMAT)MAKEFOURCC('Y', 'V', '1', '2'); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), code supplied by vendor
surfaceInfo.shared_handle = (HANDLE)1;
cl_int retVal = CL_SUCCESS;
cl_uint plane = 0;

View File

@ -1,5 +1,5 @@
/*
* Copyright (C) 2018-2023 Intel Corporation
* Copyright (C) 2018-2025 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@ -154,7 +154,7 @@ TEST(EventBuilder, givenVirtualEventWithSubmittedCommandAsParentThenFinalizeNotA
virtualEvent.eventWithoutCommand = false;
virtualEvent.submittedCmd.exchange(command.release());
EventBuilder eventBuilder;
EventBuilder eventBuilder; // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks), NEO-14033
EXPECT_EQ(nullptr, eventBuilder.getEvent());
constexpr int constrParam1 = 7;

View File

@ -1,5 +1,5 @@
/*
* Copyright (C) 2018-2023 Intel Corporation
* Copyright (C) 2018-2025 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@ -668,8 +668,8 @@ TEST(EventsTracker, givenEventsFromDifferentThreadsThenDumpingProperly) {
UserEvent uEvent2;
evTrackerMockMT->getList()->pushFrontOne(*new TrackedEvent{&uEvent1, 2});
evTrackerMockMT->getList()->pushFrontOne(*new TrackedEvent{&uEvent2, 3});
evTrackerMockMT->dump();
evTrackerMockMT->getList()->pushFrontOne(*new TrackedEvent{&uEvent2, 3}); // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks), NEO-14033
evTrackerMockMT->dump(); // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks), NEO-14033
std::stringstream expected;
expected << "digraph events_registry_" << evTrackerMockMT

View File

@ -1,5 +1,5 @@
/*
* Copyright (C) 2018-2023 Intel Corporation
* Copyright (C) 2018-2025 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@ -51,6 +51,9 @@ struct ClIntelSharingFormatQueryDX9 : public ApiTests {
D3DFMT_A8L8, D3DFMT_A32B32G32R32F, D3DFMT_A16B16G16R16F, D3DFMT_A16B16G16R16,
D3DFMT_A8B8G8R8, D3DFMT_X8B8G8R8, D3DFMT_A8R8G8B8, D3DFMT_X8R8G8B8};
// Silence all checks for FOURCC codes out of range of D3DFORMAT
// format are supplied by vendor and many codes are not listed in enum
// NOLINTBEGIN(clang-analyzer-optin.core.EnumCastOutOfRange)
supportedPlanarFormats = {D3DFMT_YUY2, D3DFMT_UYVY,
static_cast<D3DFORMAT>(MAKEFOURCC('N', 'V', '1', '2')),
static_cast<D3DFORMAT>(MAKEFOURCC('Y', 'V', '1', '2')),
@ -61,6 +64,7 @@ struct ClIntelSharingFormatQueryDX9 : public ApiTests {
static_cast<D3DFORMAT>(MAKEFOURCC('Y', 'V', '1', '2'))};
supportedPlane2Formats = {static_cast<D3DFORMAT>(MAKEFOURCC('Y', 'V', '1', '2'))};
// NOLINTEND(clang-analyzer-optin.core.EnumCastOutOfRange)
retrievedFormats.assign(supportedNonPlanarFormats.size() + supportedPlanarFormats.size(), D3DFMT_UNKNOWN);
}

View File

@ -768,7 +768,7 @@ TEST_F(CompilerInterfaceTest, givenUpdatedSpecConstValuesWhenBuildProgramThenPro
auto err = pCompilerInterface->build(*pDevice, inputArgs, translationOutput);
EXPECT_EQ(TranslationOutput::ErrorCode::success, err);
}
} // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks), NEO-14033
TEST_F(CompilerInterfaceTest, GivenRequestForNewFclTranslationCtxWhenDeviceCtxIsNotAvailableThenCreateNewDeviceCtxAndUseItToReturnValidTranslationCtx) {
auto device = this->pDevice;