Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "Disable tlb flush WA on PVC and later" 

This reverts commit e0c87435e1.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
This commit is contained in:
Compute-Runtime-Validation 2022-06-22 16:39:36 +02:00 committed by Compute-Runtime-Automation
parent fb9e79cafa
commit 1bfe42350a
6 changed files with 6 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
opencl/test/unit_test/helpers/hw_helper_tests_pvc_and_later.cpp
View File

@ -79,11 +79,6 @@ HWTEST2_F(HwHelperTestPvcAndLater, givenHwHelperWhenCheckIsUpdateTaskCountFromWa
EXPECT_TRUE(hwHelper.isUpdateTaskCountFromWaitSupported());
}
HWTEST2_F(HwHelperTestPvcAndLater, givenHwHelperWhenCheckSsFlushTlbWARequiredThenReturnsFalse, IsAtLeastXeHpcCore) {
auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily);
EXPECT_FALSE(hwHelper.isFlushTlbWARequired());
}
HWTEST2_F(HwHelperTestPvcAndLater, givenComputeEngineAndCooperativeUsageWhenGetEngineGroupTypeIsCalledThenCooperativeComputeGroupTypeIsReturned, IsAtLeastXeHpcCore) {
auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily);
auto hwInfo = *::defaultHwInfo;

3
shared/source/helpers/hw_helper.h
View File

@ -106,7 +106,6 @@ class HwHelper {
virtual bool isBankOverrideRequired(const HardwareInfo &hwInfo) const = 0;
virtual uint32_t getGlobalTimeStampBits() const = 0;
virtual int32_t getDefaultThreadArbitrationPolicy() const = 0;
virtual bool isFlushTlbWARequired() const = 0;
virtual bool useOnlyGlobalTimestamps() const = 0;
virtual bool useSystemMemoryPlacementForISA(const HardwareInfo &hwInfo) const = 0;
virtual bool packedFormatsSupported() const = 0;
@ -256,8 +255,6 @@ class HwHelperHw : public HwHelper {
bool is1MbAlignmentSupported(const HardwareInfo &hwInfo, bool isCompressionEnabled) const override;
bool isFlushTlbWARequired() const override;
bool isFenceAllocationRequired(const HardwareInfo &hwInfo) const override;
void setRenderSurfaceStateForScratchResource(const RootDeviceEnvironment &rootDeviceEnvironment,

5
shared/source/helpers/hw_helper_base.inl
View File

@ -521,11 +521,6 @@ size_t HwHelperHw<GfxFamily>::getSingleTimestampPacketSize() const {
return HwHelperHw<GfxFamily>::getSingleTimestampPacketSizeHw();
}
template <typename GfxFamily>
bool HwHelperHw<GfxFamily>::isFlushTlbWARequired() const {
return true;
}
template <typename GfxFamily>
size_t HwHelperHw<GfxFamily>::getSingleTimestampPacketSizeHw() {
if (DebugManager.flags.OverrideTimestampPacketSize.get() != -1) {

5
shared/source/helpers/hw_helper_pvc_and_later.inl
View File

@ -69,9 +69,4 @@ size_t HwHelperHw<Family>::getPaddingForISAAllocation() const {
return 0xE00;
}
template <>
bool HwHelperHw<Family>::isFlushTlbWARequired() const {
return false;
}
} // namespace NEO

17
shared/source/os_interface/linux/drm_neo.cpp
View File

@ -598,18 +598,13 @@ uint32_t Drm::getVirtualMemoryAddressSpace(uint32_t vmId) {
}
void Drm::setNewResourceBoundToVM(uint32_t vmHandleId) {
auto hwInfo = this->rootDeviceEnvironment.getHardwareInfo();
auto &hwHelper = HwHelper::get(hwInfo->platform.eRenderCoreFamily);
const auto &engines = this->rootDeviceEnvironment.executionEnvironment.memoryManager->getRegisteredEngines();
for (const auto &engine : engines) {
if (engine.osContext->getDeviceBitfield().test(vmHandleId)) {
auto osContextLinux = static_cast<OsContextLinux *>(engine.osContext);
if (hwHelper.isFlushTlbWARequired()) {
const auto &engines = this->rootDeviceEnvironment.executionEnvironment.memoryManager->getRegisteredEngines();
for (const auto &engine : engines) {
if (engine.osContext->getDeviceBitfield().test(vmHandleId)) {
auto osContextLinux = static_cast<OsContextLinux *>(engine.osContext);
if (&osContextLinux->getDrm() == this) {
osContextLinux->setNewResourceBound(true);
}
if (&osContextLinux->getDrm() == this) {
osContextLinux->setNewResourceBound(true);
}
}
}

4
shared/test/unit_test/os_interface/linux/drm_residency_handler_prelim_tests.cpp
View File

@ -103,10 +103,6 @@ struct DrmMemoryOperationsHandlerBindFixture : public ::testing::Test {
using DrmMemoryOperationsHandlerBindMultiRootDeviceTest = DrmMemoryOperationsHandlerBindFixture<2u>;
TEST_F(DrmMemoryOperationsHandlerBindMultiRootDeviceTest, whenSetNewResourceBoundToVMThenAllContextsUsingThatVMHasSetNewResourceBound) {
if (!HwHelper::get(executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo()->platform.eRenderCoreFamily).isFlushTlbWARequired()) {
GTEST_SKIP();
}
mock->setNewResourceBoundToVM(1u);
for (const auto &engine : device->getAllEngines()) {