Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "fix: Remove tlb flush from DG2 and MTL" 

This reverts commit 8ef4629e50.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
This commit is contained in:
Compute-Runtime-Validation 2023-07-15 04:32:39 +02:00 committed by Compute-Runtime-Automation
parent 147867f82d
commit 204e5fd306
5 changed files with 1 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
shared/source/xe_hpg_core/dg2/os_agnostic_product_helper_dg2.inl
View File

@ -88,11 +88,6 @@ bool ProductHelperHw<gfxProduct>::isMaxThreadsForWorkgroupWARequired(const Hardw
return DG2::isG10(hwInfo) && GfxCoreHelper::isWorkaroundRequired(REVISION_A0, REVISION_A1, hwInfo, *this); return DG2::isG10(hwInfo) && GfxCoreHelper::isWorkaroundRequired(REVISION_A0, REVISION_A1, hwInfo, *this);
} }
template <>
bool ProductHelperHw<gfxProduct>::isTlbFlushRequired() const {
return false;
}
template <> template <>
void ProductHelperHw<gfxProduct>::setForceNonCoherent(void *const statePtr, const StateComputeModeProperties &properties) const { void ProductHelperHw<gfxProduct>::setForceNonCoherent(void *const statePtr, const StateComputeModeProperties &properties) const {
using STATE_COMPUTE_MODE = typename XeHpgCoreFamily::STATE_COMPUTE_MODE; using STATE_COMPUTE_MODE = typename XeHpgCoreFamily::STATE_COMPUTE_MODE;

5
shared/source/xe_hpg_core/mtl/os_agnostic_product_helper_mtl.inl
View File

@ -97,11 +97,6 @@ bool ProductHelperHw<gfxProduct>::isDummyBlitWaRequired() const {
return true; return true;
} }
template <>
bool ProductHelperHw<gfxProduct>::isTlbFlushRequired() const {
return false;
}
template <> template <>
bool ProductHelperHw<gfxProduct>::isCachingOnCpuAvailable() const { bool ProductHelperHw<gfxProduct>::isCachingOnCpuAvailable() const {
return false; return false;

2
shared/test/unit_test/os_interface/product_helper_tests.cpp
View File

@ -430,7 +430,7 @@ HWTEST2_F(ProductHelperTest, givenProductHelperWhenAskedIfIsTimestampWaitSupport
EXPECT_FALSE(productHelper->isTimestampWaitSupportedForEvents()); EXPECT_FALSE(productHelper->isTimestampWaitSupportedForEvents());
} }
HWTEST2_F(ProductHelperTest, givenProductHelperWhenAskedIfIsTlbFlushRequiredThenTrueIsReturned, IsNotXeHpgOrXeHpcCore) { HWTEST2_F(ProductHelperTest, givenProductHelperWhenAskedIfIsTlbFlushRequiredThenTrueIsReturned, IsNotPVC) {
EXPECT_TRUE(productHelper->isTlbFlushRequired()); EXPECT_TRUE(productHelper->isTlbFlushRequired());
} }

4
shared/test/unit_test/xe_hpg_core/dg2/test_product_helper_dg2.cpp
View File

@ -29,10 +29,6 @@ DG2TEST_F(Dg2ProductHelper, givenDG2WithBSteppingThenAdditionalStateBaseAddressW
EXPECT_TRUE(isWARequired); EXPECT_TRUE(isWARequired);
} }
DG2TEST_F(Dg2ProductHelper, whenCheckIsTlbFlushRequiredThenReturnProperValue) {
EXPECT_FALSE(productHelper->isTlbFlushRequired());
}
DG2TEST_F(Dg2ProductHelper, givenDG2WithA0SteppingThenMaxThreadsForWorkgroupWAIsRequired) { DG2TEST_F(Dg2ProductHelper, givenDG2WithA0SteppingThenMaxThreadsForWorkgroupWAIsRequired) {
pInHwInfo.platform.usRevId = productHelper->getHwRevIdFromStepping(REVISION_A0, pInHwInfo); pInHwInfo.platform.usRevId = productHelper->getHwRevIdFromStepping(REVISION_A0, pInHwInfo);
for (const auto &devId : dg2G10DeviceIds) { for (const auto &devId : dg2G10DeviceIds) {

4
shared/test/unit_test/xe_hpg_core/mtl/product_helper_tests_mtl.cpp
View File

@ -83,10 +83,6 @@ MTLTEST_F(MtlProductHelper, givenProductHelperWhenGettingEvictIfNecessaryFlagSup
EXPECT_TRUE(productHelper->isEvictionIfNecessaryFlagSupported()); EXPECT_TRUE(productHelper->isEvictionIfNecessaryFlagSupported());
} }
MTLTEST_F(MtlProductHelper, whenCheckIsTlbFlushRequiredThenReturnProperValue) {
EXPECT_FALSE(productHelper->isTlbFlushRequired());
}
MTLTEST_F(MtlProductHelper, givenProductHelperWhenGetCommandsStreamPropertiesSupportThenExpectCorrectValues) { MTLTEST_F(MtlProductHelper, givenProductHelperWhenGetCommandsStreamPropertiesSupportThenExpectCorrectValues) {
EXPECT_FALSE(productHelper->getScmPropertyThreadArbitrationPolicySupport()); EXPECT_FALSE(productHelper->getScmPropertyThreadArbitrationPolicySupport());