From 4916a16cc508de3ea355ec0fee574dd14391f98a Mon Sep 17 00:00:00 2001 From: "Zdanowicz, Zbigniew" Date: Tue, 29 Jan 2019 13:23:58 +0100 Subject: [PATCH] Update guidelines with rules regarding initialization of HW commands Change-Id: I96a35cb082482ca09111f391b9df6f0e3927920f --- documentation/GUIDELINES.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/documentation/GUIDELINES.md b/documentation/GUIDELINES.md index 0af5aff942..b0f166ba39 100644 --- a/documentation/GUIDELINES.md +++ b/documentation/GUIDELINES.md @@ -37,9 +37,12 @@ TEST(CommandQueueTests, givenCommandQueueWhenEnqueueWithBlockingFlagIsSetThenDri ``` # Testing mindset -* Test behaviors instead of implementations, do not focus on adding a test per every function in the +* Test behaviors instead of implementations, do not focus on adding a test per every function in the class (avoid tests for setters and getters), focus on the functionality you are adding and how it changes the driver behavior, do not bind tests to implementation. -* Make sure that test is fast, our test suite needs to complete in seconds for efficient development pace, as +* Make sure that test is fast, our test suite needs to complete in seconds for efficient development pace, as a general rule test shouldn't be longer then 1ms in Debug driver. +# Coding guidelines +* HW commands and structures used in NEO must be initialized with constants defines for each Gfx Family: i.e. PIPE_CONTROL cmd = GfxFamily::cmdInitPipeControl +* Any new HW command or structure must have its own static constant initializer added to any Gfx Family that is going to use it. \ No newline at end of file