refactor: remove not needed debug variable
Signed-off-by: Michal Mrozek <michal.mrozek@intel.com>
This commit is contained in:
parent
62619f9525
commit
52daf63a6f
|
@ -115,11 +115,9 @@ bool MemObjHelper::isSuitableForCompression(bool compressionSupported, const Mem
|
||||||
for (auto &pClDevice : context.getDevices()) {
|
for (auto &pClDevice : context.getDevices()) {
|
||||||
auto rootDeviceIndex = pClDevice->getRootDeviceIndex();
|
auto rootDeviceIndex = pClDevice->getRootDeviceIndex();
|
||||||
if (context.containsMultipleSubDevices(rootDeviceIndex)) {
|
if (context.containsMultipleSubDevices(rootDeviceIndex)) {
|
||||||
if (debugManager.flags.EnableMultiTileCompression.get() <= 0) {
|
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
|
||||||
if (preferCompression) {
|
if (preferCompression) {
|
||||||
if (properties.flags.uncompressedHint) {
|
if (properties.flags.uncompressedHint) {
|
||||||
return false;
|
return false;
|
||||||
|
|
|
@ -413,32 +413,3 @@ TEST(MemObjHelper, givenCompressionEnabledAndPreferredWhenContextRequiresResolve
|
||||||
|
|
||||||
EXPECT_TRUE(MemObjHelper::isSuitableForCompression(true, memoryProperties, context, true));
|
EXPECT_TRUE(MemObjHelper::isSuitableForCompression(true, memoryProperties, context, true));
|
||||||
}
|
}
|
||||||
|
|
||||||
TEST(MemObjHelper, givenDifferentCapabilityAndDebugFlagValuesWhenCheckingBufferCompressionSupportThenCorrectValueIsReturned) {
|
|
||||||
DebugManagerStateRestore debugRestore;
|
|
||||||
VariableBackup<bool> renderCompressedBuffersCapability{&defaultHwInfo->capabilityTable.ftrRenderCompressedBuffers};
|
|
||||||
int32_t enableMultiTileCompressionValues[] = {-1, 0, 1};
|
|
||||||
|
|
||||||
for (auto ftrRenderCompressedBuffers : ::testing::Bool()) {
|
|
||||||
renderCompressedBuffersCapability = ftrRenderCompressedBuffers;
|
|
||||||
for (auto enableMultiTileCompressionValue : enableMultiTileCompressionValues) {
|
|
||||||
debugManager.flags.EnableMultiTileCompression.set(enableMultiTileCompressionValue);
|
|
||||||
|
|
||||||
MockSpecializedContext context;
|
|
||||||
auto &device = context.getDevice(0)->getDevice();
|
|
||||||
MemoryProperties memoryProperties = ClMemoryPropertiesHelper::createMemoryProperties(0, 0, 0, &device);
|
|
||||||
|
|
||||||
bool compressionEnabled = MemObjHelper::isSuitableForCompression(GfxCoreHelper::compressedBuffersSupported(*defaultHwInfo), memoryProperties, context, true);
|
|
||||||
|
|
||||||
MockPublicAccessBuffer::getGraphicsAllocationTypeAndCompressionPreference(
|
|
||||||
memoryProperties, compressionEnabled, false);
|
|
||||||
|
|
||||||
bool expectBufferCompressed = ftrRenderCompressedBuffers && (enableMultiTileCompressionValue == 1);
|
|
||||||
if (expectBufferCompressed) {
|
|
||||||
EXPECT_TRUE(compressionEnabled);
|
|
||||||
} else {
|
|
||||||
EXPECT_FALSE(compressionEnabled);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
|
@ -181,7 +181,6 @@ DECLARE_DEBUG_VARIABLE(int32_t, OverrideMaxWorkGroupCount, -1, "-1: default, >0:
|
||||||
DECLARE_DEBUG_VARIABLE(int32_t, OverrideCmdQueueSynchronousMode, -1, "Overrides all command queues synchronous mode: -1: do not override, 0: implicit driver behavior, 1: synchronous, 2: asynchronous")
|
DECLARE_DEBUG_VARIABLE(int32_t, OverrideCmdQueueSynchronousMode, -1, "Overrides all command queues synchronous mode: -1: do not override, 0: implicit driver behavior, 1: synchronous, 2: asynchronous")
|
||||||
DECLARE_DEBUG_VARIABLE(int32_t, OverrideImmediateCmdListSynchronousMode, -1, "Overrides all immediate command lists synchronous mode: -1: do not override, 0: implicit driver behavior, 1: synchronous, 2: asynchronous")
|
DECLARE_DEBUG_VARIABLE(int32_t, OverrideImmediateCmdListSynchronousMode, -1, "Overrides all immediate command lists synchronous mode: -1: do not override, 0: implicit driver behavior, 1: synchronous, 2: asynchronous")
|
||||||
DECLARE_DEBUG_VARIABLE(int32_t, EnableStatelessCompression, -1, "-1: default, 0: disable, 1: Enable E2EC in SBA for all stateless accesses")
|
DECLARE_DEBUG_VARIABLE(int32_t, EnableStatelessCompression, -1, "-1: default, 0: disable, 1: Enable E2EC in SBA for all stateless accesses")
|
||||||
DECLARE_DEBUG_VARIABLE(int32_t, EnableMultiTileCompression, -1, "-1: default, 0: disable, 1: enable, Enables compression in multi tile scenarios.")
|
|
||||||
DECLARE_DEBUG_VARIABLE(int32_t, OverrideGmmResourceUsageField, -1, "-1: default, >=0: gmm.resourceParams.Usage is set to this value")
|
DECLARE_DEBUG_VARIABLE(int32_t, OverrideGmmResourceUsageField, -1, "-1: default, >=0: gmm.resourceParams.Usage is set to this value")
|
||||||
DECLARE_DEBUG_VARIABLE(int32_t, OverrideGmmCacheableField, -1, "-1: default, >=0: gmm Flags.Info.Cacheable is set to this value")
|
DECLARE_DEBUG_VARIABLE(int32_t, OverrideGmmCacheableField, -1, "-1: default, >=0: gmm Flags.Info.Cacheable is set to this value")
|
||||||
DECLARE_DEBUG_VARIABLE(int32_t, OverrideBufferSuitableForRenderCompression, -1, "-1: default, 0: Disable, 1: Enable")
|
DECLARE_DEBUG_VARIABLE(int32_t, OverrideBufferSuitableForRenderCompression, -1, "-1: default, 0: Disable, 1: Enable")
|
||||||
|
|
|
@ -314,7 +314,6 @@ ForceMemoryBankIndexOverride = -1
|
||||||
SynchronizeWithSemaphores = -1
|
SynchronizeWithSemaphores = -1
|
||||||
UseCrossAtomicSynchronization = -1
|
UseCrossAtomicSynchronization = -1
|
||||||
EnableStatelessCompression = -1
|
EnableStatelessCompression = -1
|
||||||
EnableMultiTileCompression = -1
|
|
||||||
EnablePrivateScratchSlot1 = -1
|
EnablePrivateScratchSlot1 = -1
|
||||||
DisablePipeControlPrecedingPostSyncCommand = -1
|
DisablePipeControlPrecedingPostSyncCommand = -1
|
||||||
UseClearColorAllocationForBlitter = false
|
UseClearColorAllocationForBlitter = false
|
||||||
|
|
Loading…
Reference in New Issue