Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Allow free of zero sized allocation 

Related-To: NEO-9236

Signed-off-by: Lukasz Jobczyk <lukasz.jobczyk@intel.com>
This commit is contained in:
Lukasz Jobczyk 2024-02-07 14:13:36 +00:00 committed by Compute-Runtime-Automation
parent d514c675df
commit 5717a726ff
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
shared/source/os_interface/windows/wddm_memory_manager.cpp
View File

@ -811,11 +811,10 @@ bool WddmMemoryManager::isMemoryBudgetExhausted() const {
bool WddmMemoryManager::validateAllocation(WddmAllocation *alloc) {
if (alloc == nullptr)
return false;
auto size = alloc->getUnderlyingBufferSize();
if (alloc->physicalMemoryReservation && !alloc->mappedPhysicalMemoryReservation) {
return true;
}
if (alloc->getGpuAddress() == 0u || size == 0 || (alloc->getDefaultHandle() == 0 && alloc->fragmentsStorage.fragmentCount == 0))
if (alloc->getGpuAddress() == 0u || (alloc->getDefaultHandle() == 0 && alloc->fragmentsStorage.fragmentCount == 0))
return false;
return true;
}

11
shared/test/unit_test/os_interface/windows/wddm_memory_manager_tests.cpp
View File

@ -3372,6 +3372,17 @@ TEST_F(MockWddmMemoryManagerTest, givenValidateAllocationFunctionWhenItIsCalledW
memoryManager.freeGraphicsMemory(wddmAlloc);
}
TEST_F(MockWddmMemoryManagerTest, givenValidateAllocationFunctionWhenItIsCalledWithZeroSizedAllocationThenSuccessIsReturned) {
wddm->init();
MockWddmMemoryManager memoryManager(executionEnvironment);
auto ptr = reinterpret_cast<void *>(0x1234);
WddmAllocation allocation{0, AllocationType::commandBuffer, ptr, castToUint64(ptr), 0, nullptr, MemoryPool::system64KBPages, 0u, 1u};
allocation.getHandleToModify(0u) = 1;
EXPECT_TRUE(memoryManager.validateAllocationMock(&allocation));
}
TEST_F(MockWddmMemoryManagerTest, givenCreateOrReleaseDeviceSpecificMemResourcesWhenCreatingMemoryManagerObjectThenTheseMethodsAreEmpty) {
wddm->init();
MockWddmMemoryManager memoryManager(executionEnvironment);