Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor: add statelessBuiltinsEnabled bool to cmdlist 

Related-To: NEO-6075
Signed-off-by: Kamil Kopryk <kamil.kopryk@intel.com>
This commit is contained in:
Kamil Kopryk 2024-07-23 15:45:06 +00:00 committed by Compute-Runtime-Automation
parent 2116808b8d
commit 635f596599
4 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
level_zero/core/source/cmdlist/cmdlist.h
View File

@ -369,6 +369,10 @@ struct CommandList : _ze_command_list_handle_t {
return taskCountUpdateFenceRequired;
}
bool isStatelessBuiltinsEnabled() const {
return statelessBuiltinsEnabled;
}
void registerCsrDcFlushForDcMitigation(NEO::CommandStreamReceiver &csr);
protected:
@ -458,6 +462,7 @@ struct CommandList : _ze_command_list_handle_t {
bool scratchAddressPatchingEnabled = false;
bool taskCountUpdateFenceRequired = false;
bool requiresDcFlushForDcMitigation = false;
bool statelessBuiltinsEnabled = false;
};
using CommandListAllocatorFn = CommandList *(*)(uint32_t);

7
level_zero/core/source/cmdlist/cmdlist_hw.inl
View File

@ -255,6 +255,7 @@ ze_result_t CommandListCoreFamily<gfxCoreFamily>::initialize(Device *device, NEO
if (NEO::debugManager.flags.OverrideThreadArbitrationPolicy.get() != -1) {
this->defaultPipelinedThreadArbitrationPolicy = NEO::debugManager.flags.OverrideThreadArbitrationPolicy.get();
}
this->statelessBuiltinsEnabled = compilerProductHelper.isForceToStatelessRequired();
this->commandContainer.doubleSbaWaRef() = this->doubleSbaWa;
this->commandContainer.l1CachePolicyDataRef() = &this->l1CachePolicyData;
@ -1472,10 +1473,8 @@ ze_result_t CommandListCoreFamily<gfxCoreFamily>::appendMemoryCopy(void *dstptr,
uintptr_t leftSize = 0;
uintptr_t rightSize = 0;
uintptr_t middleSizeBytes = 0;
bool isStateless = this->cmdListHeapAddressModel == NEO::HeapAddressModel::globalStateless;
if (neoDevice->getCompilerProductHelper().isForceToStatelessRequired()) {
isStateless = true;
}
bool isStateless = (this->cmdListHeapAddressModel == NEO::HeapAddressModel::globalStateless) || this->isStatelessBuiltinsEnabled();
const bool isHeapless = this->isHeaplessModeEnabled();
if (!isCopyOnlyEnabled) {

1
level_zero/core/test/unit_tests/mocks/mock_cmdlist.h
View File

@ -306,6 +306,7 @@ struct WhiteBox<::L0::CommandListImp> : public ::L0::CommandListImp {
using BaseClass::signalAllEventPackets;
using BaseClass::stateBaseAddressTracking;
using BaseClass::stateComputeModeTracking;
using BaseClass::statelessBuiltinsEnabled;
using CommandList::flags;
using CommandList::internalUsage;
using CommandList::kernelWithAssertAppended;

2
level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_1.cpp
View File

@ -3034,6 +3034,7 @@ TEST_F(CommandListCreate, givenCreatedCommandListWhenGettingTrackingFlagsThenDef
auto &l0GfxCoreHelper = rootDeviceEnvironment.getHelper<L0GfxCoreHelper>();
auto &productHelper = rootDeviceEnvironment.getHelper<NEO::ProductHelper>();
auto &compilerProductHelper = rootDeviceEnvironment.getHelper<NEO::CompilerProductHelper>();
ze_result_t returnValue;
std::unique_ptr<L0::ult::CommandList> commandList(CommandList::whiteboxCast(CommandList::create(productFamily, device, NEO::EngineGroupType::renderCompute, 0u, returnValue, false)));
@ -3062,6 +3063,7 @@ TEST_F(CommandListCreate, givenCreatedCommandListWhenGettingTrackingFlagsThenDef
EXPECT_EQ(expectedDispatchCmdListBatchBufferAsPrimary, commandList->getCmdListBatchBufferFlag());
EXPECT_EQ(commandList->heaplessModeEnabled, commandList->scratchAddressPatchingEnabled);
EXPECT_EQ(commandList->statelessBuiltinsEnabled, compilerProductHelper.isForceToStatelessRequired());
}
TEST(BuiltinTypeHelperTest, givenNonStatelessAndNonHeaplessWhenAdjustBuiltinTypeIsCalledThenCorrectBuiltinTypeIsReturned) {