Media/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-09-15 13:01:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

TBX CommandStreamReceiver fix for makeCoherent

Browse Source 
- makeCoherent should be called after TBX finished processing
 - this is when tagAddress is updated with taskCount
makeCoherent is called from makeNonResident which is invoked just
after flush and may happen before TBX server finished processing
leading to invalid data to be read back to CPU accessible memory

- this fix adds waiting for taskCount to blocking calls for TBX CSR
before calling makeNonResident on surfaces to guarantee correct data
from TBX server is ready.

Change-Id: I498a5454e0826eec2a5413a08880af40268550e1
This commit is contained in:
Hoppe, Mateusz
2018-07-03 17:56:55 +02:00
committed by sys_ocldev
parent 8fd7f6a8ce
commit 64277ee849
14 changed files with 100 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
unit_tests/kernel/kernel_image_arg_tests.cpp
View File

@ -212,7 +212,7 @@ HWTEST_F(KernelImageArgTest, givenImgWithMcsAllocWhenMakeResidentThenMakeMcsAllo
pKernel->makeResident(*csr.get());
EXPECT_TRUE(csr->isMadeResident(mcsAlloc));
csr->makeSurfacePackNonResident(nullptr);
csr->makeSurfacePackNonResident(nullptr, false);
EXPECT_TRUE(csr->isMadeNonResident(mcsAlloc));

2
unit_tests/kernel/kernel_tests.cpp
View File

@ -506,7 +506,7 @@ TEST_F(KernelPrivateSurfaceTest, testPrivateSurface) {
pKernel->makeResident(*csr.get());
EXPECT_EQ(1u, csr->residency.size());
csr->makeSurfacePackNonResident(nullptr);
csr->makeSurfacePackNonResident(nullptr, false);
pKernel->updateWithCompletionStamp(*csr.get(), nullptr);
EXPECT_EQ(0u, csr->residency.size());