Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feature: store walker command in cpu memory for append launch kernel 

Related-To: NEO-10066

Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
This commit is contained in:
Zbigniew Zdanowicz 2024-04-16 20:52:22 +00:00 committed by Compute-Runtime-Automation
parent 96347c7847
commit 64d1adf2bf
3 changed files with 40 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
level_zero/core/source/cmdlist/cmdlist_hw_xehp_and_later.inl
View File

@ -327,7 +327,7 @@ ze_result_t CommandListCoreFamily<gfxCoreFamily>::appendLaunchKernelWithParams(K
dsh, // dynamicStateHeap
reinterpret_cast<const void *>(&threadGroupDimensions), // threadGroupDimensions
nullptr, // outWalkerPtr
nullptr, // cpuWalkerBuffer
launchParams.cmdWalkerBuffer, // cpuWalkerBuffer
&additionalCommands, // additionalCommands
kernelPreemptionMode, // preemptionMode
launchParams.requiredPartitionDim, // requiredPartitionDim

1
level_zero/core/source/cmdlist/cmdlist_launch_params.h
View File

@ -46,6 +46,7 @@ using CommandToPatchContainer = std::vector<CommandToPatch>;
struct CmdListKernelLaunchParams {
void *outWalker = nullptr;
void *cmdWalkerBuffer = nullptr;
CommandToPatch *outSyncCommand = nullptr;
CommandToPatchContainer *outListCommands = nullptr;
NEO::RequiredPartitionDim requiredPartitionDim = NEO::RequiredPartitionDim::none;

38
level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_xehp_and_later.cpp
View File

@ -2833,5 +2833,43 @@ HWTEST2_F(CommandListAppendLaunchKernel,
EXPECT_EQ(residencyContainer.end(), eventAllocIt);
}
HWTEST2_F(CommandListAppendLaunchKernel,
givenCmdListParamHasWalkerCpuBufferWhenAppendingKernelThenCopiedWalkerHasTheSameContentAsInGfxMemory,
IsAtLeastXeHpCore) {
using DefaultWalkerType = typename FamilyType::DefaultWalkerType;
Mock<::L0::KernelImp> kernel;
auto mockModule = std::unique_ptr<Module>(new Mock<Module>(device, nullptr));
kernel.module = mockModule.get();
auto commandList = std::make_unique<WhiteBox<::L0::CommandListCoreFamily<gfxCoreFamily>>>();
auto result = commandList->initialize(device, NEO::EngineGroupType::compute, 0);
ASSERT_EQ(ZE_RESULT_SUCCESS, result);
auto &commandContainer = commandList->getCmdContainer();
auto cmdStream = commandContainer.getCommandStream();
auto walkerBuffer = std::make_unique<DefaultWalkerType>();
ze_group_count_t groupCount{1, 1, 1};
CmdListKernelLaunchParams launchParams = {};
launchParams.cmdWalkerBuffer = walkerBuffer.get();
auto commandStreamOffset = cmdStream->getUsed();
result = commandList->appendLaunchKernel(kernel.toHandle(), groupCount, nullptr, 0, nullptr, launchParams, false);
ASSERT_EQ(ZE_RESULT_SUCCESS, result);
GenCmdList cmdList;
ASSERT_TRUE(FamilyType::Parse::parseCommandBuffer(
cmdList,
ptrOffset(cmdStream->getCpuBase(), commandStreamOffset),
cmdStream->getUsed() - commandStreamOffset));
auto computeWalkerList = findAll<DefaultWalkerType *>(cmdList.begin(), cmdList.end());
ASSERT_EQ(1u, computeWalkerList.size());
auto walkerGfxMemory = reinterpret_cast<DefaultWalkerType *>(*computeWalkerList[0]);
EXPECT_EQ(0, memcmp(walkerGfxMemory, launchParams.cmdWalkerBuffer, sizeof(DefaultWalkerType)));
}
} // namespace ult
} // namespace L0