From 7183d300968fbaaf8d8dc9179938a2c264da5b26 Mon Sep 17 00:00:00 2001 From: Pawel Wilma Date: Tue, 26 May 2020 15:09:50 +0200 Subject: [PATCH] On TGLLP DepthCacheFlush in PC has to be set together with DepthStall Change-Id: I8d19f1d2de513ad559c565bf1fc4308912b9ee64 Signed-off-by: Pawel Wilma --- shared/source/gen12lp/preamble_gen12lp.cpp | 1 + shared/test/unit_test/gen12lp/test_preamble_gen12lp.cpp | 2 ++ 2 files changed, 3 insertions(+) diff --git a/shared/source/gen12lp/preamble_gen12lp.cpp b/shared/source/gen12lp/preamble_gen12lp.cpp index 9ce1677940..19df21129b 100644 --- a/shared/source/gen12lp/preamble_gen12lp.cpp +++ b/shared/source/gen12lp/preamble_gen12lp.cpp @@ -68,6 +68,7 @@ void PreambleHelper::addPipeControlBeforeVfeCmd(LinearStream *pComm if (!EngineHelpers::isCcs(engineType)) { cmd.setRenderTargetCacheFlushEnable(true); cmd.setDepthCacheFlushEnable(true); + cmd.setDepthStallEnable(true); } cmd.setDcFlushEnable(true); } diff --git a/shared/test/unit_test/gen12lp/test_preamble_gen12lp.cpp b/shared/test/unit_test/gen12lp/test_preamble_gen12lp.cpp index e61a0eb9ba..ad0798e027 100644 --- a/shared/test/unit_test/gen12lp/test_preamble_gen12lp.cpp +++ b/shared/test/unit_test/gen12lp/test_preamble_gen12lp.cpp @@ -70,6 +70,7 @@ TGLLPTEST_F(Gen12LpPreambleVfeState, WaOff) { const auto &pc = *reinterpret_cast(*itorPC); EXPECT_FALSE(pc.getRenderTargetCacheFlushEnable()); EXPECT_FALSE(pc.getDepthCacheFlushEnable()); + EXPECT_FALSE(pc.getDepthStallEnable()); EXPECT_FALSE(pc.getDcFlushEnable()); EXPECT_EQ(1u, pc.getCommandStreamerStallEnable()); } @@ -108,6 +109,7 @@ TGLLPTEST_F(Gen12LpPreambleVfeState, givenRcsEngineWhenWaIsSetThenAppropriatePip const auto &pc = *reinterpret_cast(*itorPC); EXPECT_TRUE(pc.getRenderTargetCacheFlushEnable()); EXPECT_TRUE(pc.getDepthCacheFlushEnable()); + EXPECT_TRUE(pc.getDepthStallEnable()); EXPECT_TRUE(pc.getDcFlushEnable()); EXPECT_EQ(1u, pc.getCommandStreamerStallEnable()); }