From a15de0c4f6b4f4b8a43184cbb72d646adc8db3c9 Mon Sep 17 00:00:00 2001 From: Szymon Morek Date: Mon, 24 Mar 2025 09:08:49 +0000 Subject: [PATCH] performance: enable ULLS on LNL Linux Related-To: NEO-9004 Signed-off-by: Szymon Morek --- .../xe2_hpg_core/lnl/os_agnostic_product_helper_lnl.inl | 5 +++++ shared/source/xe2_hpg_core/windows/product_helper_lnl.cpp | 5 ----- .../lnl/linux/product_helper_tests_lnl_linux.cpp | 4 ---- .../unit_test/xe2_hpg_core/lnl/product_helper_tests_lnl.cpp | 4 ++++ .../lnl/windows/product_helper_tests_lnl_windows.cpp | 6 +----- 5 files changed, 10 insertions(+), 14 deletions(-) diff --git a/shared/source/xe2_hpg_core/lnl/os_agnostic_product_helper_lnl.inl b/shared/source/xe2_hpg_core/lnl/os_agnostic_product_helper_lnl.inl index 249d28b300..c395c6d147 100644 --- a/shared/source/xe2_hpg_core/lnl/os_agnostic_product_helper_lnl.inl +++ b/shared/source/xe2_hpg_core/lnl/os_agnostic_product_helper_lnl.inl @@ -35,6 +35,11 @@ std::optional ProductHelperHw::getPreferr return GfxMemoryAllocationMethod::allocateByKmd; } +template <> +bool ProductHelperHw::isDirectSubmissionSupported(ReleaseHelper *releaseHelper) const { + return true; +} + template <> bool ProductHelperHw::blitEnqueuePreferred(bool isWriteToImageFromBuffer) const { return isWriteToImageFromBuffer; diff --git a/shared/source/xe2_hpg_core/windows/product_helper_lnl.cpp b/shared/source/xe2_hpg_core/windows/product_helper_lnl.cpp index d591755b77..c57c478554 100644 --- a/shared/source/xe2_hpg_core/windows/product_helper_lnl.cpp +++ b/shared/source/xe2_hpg_core/windows/product_helper_lnl.cpp @@ -47,11 +47,6 @@ uint64_t ProductHelperHw::overridePatIndex(bool isUncachedType, uint return patIndex; } -template <> -bool ProductHelperHw::isDirectSubmissionSupported(ReleaseHelper *releaseHelper) const { - return true; -} - template <> bool ProductHelperHw::restartDirectSubmissionForHostptrFree() const { return true; diff --git a/shared/test/unit_test/xe2_hpg_core/lnl/linux/product_helper_tests_lnl_linux.cpp b/shared/test/unit_test/xe2_hpg_core/lnl/linux/product_helper_tests_lnl_linux.cpp index 4bc92815eb..ef984e32b4 100644 --- a/shared/test/unit_test/xe2_hpg_core/lnl/linux/product_helper_tests_lnl_linux.cpp +++ b/shared/test/unit_test/xe2_hpg_core/lnl/linux/product_helper_tests_lnl_linux.cpp @@ -60,10 +60,6 @@ LNLTEST_F(LnlProductHelperLinux, givenProductHelperWhenAskedIsKmdMigrationSuppor EXPECT_FALSE(productHelper->isKmdMigrationSupported()); } -LNLTEST_F(LnlProductHelperLinux, givenProductHelperWhenCheckDirectSubmissionSupportedThenFalseIsReturned) { - EXPECT_FALSE(productHelper->isDirectSubmissionSupported(releaseHelper)); -} - LNLTEST_F(LnlProductHelperLinux, givenProductHelperWhenCheckIsCopyBufferRectSplitSupportedThenReturnsTrue) { EXPECT_TRUE(productHelper->isCopyBufferRectSplitSupported()); } diff --git a/shared/test/unit_test/xe2_hpg_core/lnl/product_helper_tests_lnl.cpp b/shared/test/unit_test/xe2_hpg_core/lnl/product_helper_tests_lnl.cpp index 54a267bbf1..0170c74a2a 100644 --- a/shared/test/unit_test/xe2_hpg_core/lnl/product_helper_tests_lnl.cpp +++ b/shared/test/unit_test/xe2_hpg_core/lnl/product_helper_tests_lnl.cpp @@ -164,3 +164,7 @@ LNLTEST_F(LnlProductHelper, givenProductHelperWhenCheckingIsDeviceUsmAllocationR LNLTEST_F(LnlProductHelper, givenProductHelperWhenCheckingIsBufferPoolAllocatorSupportedThenCorrectValueIsReturned) { EXPECT_TRUE(productHelper->isBufferPoolAllocatorSupported()); } + +LNLTEST_F(LnlProductHelper, givenProductHelperWhenCheckDirectSubmissionSupportedThenTrueIsReturned) { + EXPECT_TRUE(productHelper->isDirectSubmissionSupported(releaseHelper)); +} diff --git a/shared/test/unit_test/xe2_hpg_core/lnl/windows/product_helper_tests_lnl_windows.cpp b/shared/test/unit_test/xe2_hpg_core/lnl/windows/product_helper_tests_lnl_windows.cpp index b691032b52..284c236a69 100644 --- a/shared/test/unit_test/xe2_hpg_core/lnl/windows/product_helper_tests_lnl_windows.cpp +++ b/shared/test/unit_test/xe2_hpg_core/lnl/windows/product_helper_tests_lnl_windows.cpp @@ -19,10 +19,6 @@ using namespace NEO; using LnlProductHelperWindows = ProductHelperTest; -LNLTEST_F(LnlProductHelperWindows, givenProductHelperWhenCheckDirectSubmissionSupportedThenTrueIsReturned) { - EXPECT_TRUE(productHelper->isDirectSubmissionSupported(releaseHelper)); -} - LNLTEST_F(LnlProductHelperWindows, givenProductHelperWhenDcFlushMitigationThenReturnFalse) { EXPECT_FALSE(productHelper->mitigateDcFlush()); EXPECT_FALSE(productHelper->isDcFlushMitigated()); @@ -92,4 +88,4 @@ LNLTEST_F(LnlProductHelperWindows, givenOverrideDirectSubmissionTimeoutsCalledTh productHelper->overrideDirectSubmissionTimeouts(timeout, maxTimeout); EXPECT_EQ(timeout.count(), 2'000); EXPECT_EQ(maxTimeout.count(), 3'000); -} \ No newline at end of file +}