Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor: add debug message about the zero engine info size 

Signed-off-by: Krzysztof Gibala <krzysztof.gibala@intel.com>
This commit is contained in:
Krzysztof Gibala 2024-04-25 15:08:27 +00:00 committed by Compute-Runtime-Automation
parent 06faaab5bb
commit a70aaa72ed
2 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
shared/source/os_interface/linux/drm_neo.cpp
View File

@ -976,6 +976,10 @@ bool Drm::queryMemoryInfo() {
bool Drm::queryEngineInfo(bool isSysmanEnabled) {
this->engineInfo = ioctlHelper->createEngineInfo(isSysmanEnabled);
if (this->engineInfo && this->engineInfo.get()->engines.size() == 0) {
printDebugString(debugManager.flags.PrintDebugMessages.get(), stderr, "%s", "FATAL: Engine info size is equal to 0.\n");
}
return this->engineInfo != nullptr;
}

33
shared/test/unit_test/os_interface/linux/drm_engine_info_prelim_tests.cpp
View File

@ -92,6 +92,39 @@ TEST(DrmTest, givenMemRegionQueryNotSupportedWhenQueryingMemRegionInfoThenFailGr
EXPECT_EQ(nullptr, drm->engineInfo);
}
class MockIoctlHelperEngineInfoDetection : public IoctlHelperPrelim20 {
public:
using IoctlHelperPrelim20::IoctlHelperPrelim20;
std::unique_ptr<EngineInfo> createEngineInfo(bool isSysmanEnabled) override {
std::vector<NEO::EngineCapabilities> engineInfo(0);
return std::make_unique<EngineInfo>(&drm, engineInfo);
}
};
TEST(DrmTest, givenEngineQueryOnIncorrectSetupWithZeroEnginesThenProperDebugMessageIsPrinted) {
DebugManagerStateRestore dbgState;
debugManager.flags.PrintDebugMessages.set(1);
auto executionEnvironment = std::make_unique<MockExecutionEnvironment>();
executionEnvironment->rootDeviceEnvironments[0]->initGmm();
auto drm = std::make_unique<DrmQueryMock>(*executionEnvironment->rootDeviceEnvironments[0]);
auto ioctlHelper = std::make_unique<MockIoctlHelperEngineInfoDetection>(*drm);
drm->ioctlHelper.reset(ioctlHelper.release());
testing::internal::CaptureStderr();
drm->queryEngineInfo();
EXPECT_EQ(0u, drm->engineInfo.get()->engines.size());
std::string output = testing::internal::GetCapturedStderr();
std::string expectedError = "FATAL: Engine info size is equal to 0.\n";
EXPECT_EQ(output, expectedError);
}
TEST(DrmTest, givenDistanceQueryNotSupportedWhenQueryingDistanceInfoThenFailGracefully) {
auto executionEnvironment = std::make_unique<MockExecutionEnvironment>();
executionEnvironment->rootDeviceEnvironments[0]->initGmm();