diff --git a/shared/source/release_helper/release_helper.h b/shared/source/release_helper/release_helper.h index c9d3a218b0..4875589ff8 100644 --- a/shared/source/release_helper/release_helper.h +++ b/shared/source/release_helper/release_helper.h @@ -58,7 +58,6 @@ class ReleaseHelper { virtual uint32_t getAdditionalExtraCaps() const = 0; virtual uint32_t getStackSizePerRay() const = 0; virtual bool isLocalOnlyAllowed() const = 0; - virtual bool isDisablingMsaaRequired() const = 0; virtual bool isDummyBlitWaRequired() const = 0; virtual const SizeToPreferredSlmValueArray &getSizeToPreferredSlmValue(bool isHeapless) const = 0; virtual bool isNumRtStacksPerDssFixedValue() const = 0; @@ -100,7 +99,6 @@ class ReleaseHelperHw : public ReleaseHelper { uint32_t getAdditionalExtraCaps() const override; uint32_t getStackSizePerRay() const override; bool isLocalOnlyAllowed() const override; - bool isDisablingMsaaRequired() const override; bool isDummyBlitWaRequired() const override; const SizeToPreferredSlmValueArray &getSizeToPreferredSlmValue(bool isHeapless) const override; bool isNumRtStacksPerDssFixedValue() const override; diff --git a/shared/source/release_helper/release_helper_3000.cpp b/shared/source/release_helper/release_helper_3000.cpp index 0e9862dc8c..c33040b23b 100644 --- a/shared/source/release_helper/release_helper_3000.cpp +++ b/shared/source/release_helper/release_helper_3000.cpp @@ -37,11 +37,6 @@ bool ReleaseHelperHw::isLocalOnlyAllowed() const { return false; } -template <> -bool ReleaseHelperHw::isDisablingMsaaRequired() const { - return (hardwareIpVersion.value == AOT::PTL_H_A0); -} - template <> uint32_t ReleaseHelperHw::getStackSizePerRay() const { return 64u; diff --git a/shared/source/release_helper/release_helper_3001.cpp b/shared/source/release_helper/release_helper_3001.cpp index af8961e4a9..f879e8c5e3 100644 --- a/shared/source/release_helper/release_helper_3001.cpp +++ b/shared/source/release_helper/release_helper_3001.cpp @@ -37,11 +37,6 @@ bool ReleaseHelperHw::isLocalOnlyAllowed() const { return false; } -template <> -bool ReleaseHelperHw::isDisablingMsaaRequired() const { - return (hardwareIpVersion.value == AOT::PTL_U_A0); -} - template <> bool ReleaseHelperHw::isBindlessAddressingDisabled() const { return false; diff --git a/shared/source/release_helper/release_helper_base.inl b/shared/source/release_helper/release_helper_base.inl index e81506159c..792badfaae 100644 --- a/shared/source/release_helper/release_helper_base.inl +++ b/shared/source/release_helper/release_helper_base.inl @@ -1,5 +1,5 @@ /* - * Copyright (C) 2023-2024 Intel Corporation + * Copyright (C) 2023-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -137,11 +137,6 @@ bool ReleaseHelperHw::isLocalOnlyAllowed() const { return true; } -template -bool ReleaseHelperHw::isDisablingMsaaRequired() const { - return false; -} - template bool ReleaseHelperHw::isDummyBlitWaRequired() const { return false; diff --git a/shared/source/xe3_core/command_encoder_xe3_core.cpp b/shared/source/xe3_core/command_encoder_xe3_core.cpp index 365137cb47..1a2d06f534 100644 --- a/shared/source/xe3_core/command_encoder_xe3_core.cpp +++ b/shared/source/xe3_core/command_encoder_xe3_core.cpp @@ -116,10 +116,7 @@ void EncodeMemoryPrefetch::programMemoryPrefetch(LinearStream &commandSt template <> void EncodeSurfaceState::setAuxParamsForMCSCCS(R_SURFACE_STATE *surfaceState, const ReleaseHelper *releaseHelper) { - UNRECOVERABLE_IF(releaseHelper == nullptr); - if (releaseHelper->isDisablingMsaaRequired()) { - surfaceState->setAuxiliarySurfaceMode(AUXILIARY_SURFACE_MODE::AUXILIARY_SURFACE_MODE_AUX_NONE); - } + surfaceState->setAuxiliarySurfaceMode(AUXILIARY_SURFACE_MODE::AUXILIARY_SURFACE_MODE_AUX_MCS); } template <> diff --git a/shared/test/common/mocks/mock_release_helper.h b/shared/test/common/mocks/mock_release_helper.h index 703c037937..08099b6f8e 100644 --- a/shared/test/common/mocks/mock_release_helper.h +++ b/shared/test/common/mocks/mock_release_helper.h @@ -1,5 +1,5 @@ /* - * Copyright (C) 2023-2024 Intel Corporation + * Copyright (C) 2023-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -38,7 +38,6 @@ class MockReleaseHelper : public ReleaseHelper { ADDMETHOD_CONST_NOBASE(getAdditionalExtraCaps, uint32_t, {}, ()); ADDMETHOD_CONST_NOBASE(getStackSizePerRay, uint32_t, {}, ()); ADDMETHOD_CONST_NOBASE(isLocalOnlyAllowed, bool, {}, ()); - ADDMETHOD_CONST_NOBASE(isDisablingMsaaRequired, bool, false, ()); ADDMETHOD_CONST_NOBASE(isDummyBlitWaRequired, bool, false, ()); ADDMETHOD_CONST_NOBASE(isNumRtStacksPerDssFixedValue, bool, true, ()); ADDMETHOD_CONST_NOBASE(getFtrXe2Compression, bool, false, ()); diff --git a/shared/test/unit_test/release_helper/release_helper_12_55_tests.cpp b/shared/test/unit_test/release_helper/release_helper_12_55_tests.cpp index e333875616..8327883fe5 100644 --- a/shared/test/unit_test/release_helper/release_helper_12_55_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_12_55_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2023-2024 Intel Corporation + * Copyright (C) 2023-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -40,7 +40,6 @@ TEST_F(ReleaseHelper1255Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(8u, releaseHelper->getNumThreadsPerEu()); EXPECT_EQ(0u, releaseHelper->getStackSizePerRay()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); - EXPECT_FALSE(releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); EXPECT_FALSE(releaseHelper->getFtrXe2Compression()); } diff --git a/shared/test/unit_test/release_helper/release_helper_12_56_tests.cpp b/shared/test/unit_test/release_helper/release_helper_12_56_tests.cpp index e1dbe2c10c..bcfd330c61 100644 --- a/shared/test/unit_test/release_helper/release_helper_12_56_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_12_56_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2023-2024 Intel Corporation + * Copyright (C) 2023-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -40,7 +40,6 @@ TEST_F(ReleaseHelper1256Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(8u, releaseHelper->getNumThreadsPerEu()); EXPECT_EQ(0u, releaseHelper->getStackSizePerRay()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); - EXPECT_FALSE(releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); EXPECT_FALSE(releaseHelper->getFtrXe2Compression()); } diff --git a/shared/test/unit_test/release_helper/release_helper_12_57_tests.cpp b/shared/test/unit_test/release_helper/release_helper_12_57_tests.cpp index 1bdb7a0bea..9355aa171c 100644 --- a/shared/test/unit_test/release_helper/release_helper_12_57_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_12_57_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2023-2024 Intel Corporation + * Copyright (C) 2023-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -40,7 +40,6 @@ TEST_F(ReleaseHelper1257Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(8u, releaseHelper->getNumThreadsPerEu()); EXPECT_EQ(0u, releaseHelper->getStackSizePerRay()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); - EXPECT_FALSE(releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); EXPECT_FALSE(releaseHelper->getFtrXe2Compression()); } diff --git a/shared/test/unit_test/release_helper/release_helper_12_60_tests.cpp b/shared/test/unit_test/release_helper/release_helper_12_60_tests.cpp index 067d05b725..57978cce38 100644 --- a/shared/test/unit_test/release_helper/release_helper_12_60_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_12_60_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2023-2024 Intel Corporation + * Copyright (C) 2023-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -37,7 +37,6 @@ TEST_F(ReleaseHelper1260Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(8u, releaseHelper->getNumThreadsPerEu()); EXPECT_EQ(0u, releaseHelper->getStackSizePerRay()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); - EXPECT_FALSE(releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); EXPECT_FALSE(releaseHelper->getFtrXe2Compression()); } diff --git a/shared/test/unit_test/release_helper/release_helper_12_61_tests.cpp b/shared/test/unit_test/release_helper/release_helper_12_61_tests.cpp index a66ae24b60..6851793a4f 100644 --- a/shared/test/unit_test/release_helper/release_helper_12_61_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_12_61_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2024 Intel Corporation + * Copyright (C) 2024-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -36,7 +36,6 @@ TEST_F(ReleaseHelper1261Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(8u, releaseHelper->getNumThreadsPerEu()); EXPECT_EQ(0u, releaseHelper->getStackSizePerRay()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); - EXPECT_FALSE(releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); EXPECT_FALSE(releaseHelper->getFtrXe2Compression()); } diff --git a/shared/test/unit_test/release_helper/release_helper_12_70_tests.cpp b/shared/test/unit_test/release_helper/release_helper_12_70_tests.cpp index 4d5637179c..0f58fac863 100644 --- a/shared/test/unit_test/release_helper/release_helper_12_70_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_12_70_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2023-2024 Intel Corporation + * Copyright (C) 2023-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -41,7 +41,6 @@ TEST_F(ReleaseHelper1270Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(8u, releaseHelper->getNumThreadsPerEu()); EXPECT_EQ(0u, releaseHelper->getStackSizePerRay()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); - EXPECT_FALSE(releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); EXPECT_FALSE(releaseHelper->getFtrXe2Compression()); } diff --git a/shared/test/unit_test/release_helper/release_helper_12_71_tests.cpp b/shared/test/unit_test/release_helper/release_helper_12_71_tests.cpp index 878a09f2ec..9dacf75cce 100644 --- a/shared/test/unit_test/release_helper/release_helper_12_71_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_12_71_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2023-2024 Intel Corporation + * Copyright (C) 2023-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -41,7 +41,6 @@ TEST_F(ReleaseHelper1271Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(8u, releaseHelper->getNumThreadsPerEu()); EXPECT_EQ(0u, releaseHelper->getStackSizePerRay()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); - EXPECT_FALSE(releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); EXPECT_FALSE(releaseHelper->getFtrXe2Compression()); } diff --git a/shared/test/unit_test/release_helper/release_helper_12_74_tests.cpp b/shared/test/unit_test/release_helper/release_helper_12_74_tests.cpp index ac3ce91302..6528a00eec 100644 --- a/shared/test/unit_test/release_helper/release_helper_12_74_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_12_74_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2023-2024 Intel Corporation + * Copyright (C) 2023-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -39,7 +39,6 @@ TEST_F(ReleaseHelper1274Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(8u, releaseHelper->getNumThreadsPerEu()); EXPECT_EQ(0u, releaseHelper->getStackSizePerRay()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); - EXPECT_FALSE(releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); EXPECT_FALSE(releaseHelper->getFtrXe2Compression()); } diff --git a/shared/test/unit_test/release_helper/release_helper_20_01_tests.cpp b/shared/test/unit_test/release_helper/release_helper_20_01_tests.cpp index a81074f18f..bfc690594d 100644 --- a/shared/test/unit_test/release_helper/release_helper_20_01_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_20_01_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2024 Intel Corporation + * Copyright (C) 2024-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -39,7 +39,6 @@ TEST_F(ReleaseHelper2001Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(8u, releaseHelper->getNumThreadsPerEu()); EXPECT_EQ(0u, releaseHelper->getStackSizePerRay()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); - EXPECT_FALSE(releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isGlobalBindlessAllocatorEnabled()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); } diff --git a/shared/test/unit_test/release_helper/release_helper_20_04_tests.cpp b/shared/test/unit_test/release_helper/release_helper_20_04_tests.cpp index beba9fbe83..a848906161 100644 --- a/shared/test/unit_test/release_helper/release_helper_20_04_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_20_04_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2024 Intel Corporation + * Copyright (C) 2024-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -40,7 +40,6 @@ TEST_F(ReleaseHelper2004Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(8u, releaseHelper->getNumThreadsPerEu()); EXPECT_EQ(0u, releaseHelper->getStackSizePerRay()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); - EXPECT_FALSE(releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isGlobalBindlessAllocatorEnabled()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); EXPECT_FALSE(releaseHelper->getFtrXe2Compression()); diff --git a/shared/test/unit_test/release_helper/release_helper_30_00_tests.cpp b/shared/test/unit_test/release_helper/release_helper_30_00_tests.cpp index c242ae6f4b..98147f27b4 100644 --- a/shared/test/unit_test/release_helper/release_helper_30_00_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_30_00_tests.cpp @@ -39,7 +39,6 @@ TEST_F(ReleaseHelper3000Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(10u, releaseHelper->getNumThreadsPerEu()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); EXPECT_EQ(64u, releaseHelper->getStackSizePerRay()); - EXPECT_EQ(revision == 0, releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); EXPECT_EQ(revision != 0, releaseHelper->getFtrXe2Compression()); } diff --git a/shared/test/unit_test/release_helper/release_helper_30_01_tests.cpp b/shared/test/unit_test/release_helper/release_helper_30_01_tests.cpp index 49c0f0bb31..1543fa7953 100644 --- a/shared/test/unit_test/release_helper/release_helper_30_01_tests.cpp +++ b/shared/test/unit_test/release_helper/release_helper_30_01_tests.cpp @@ -39,7 +39,6 @@ TEST_F(ReleaseHelper3001Tests, whenGettingCapabilitiesThenCorrectPropertiesAreRe EXPECT_EQ(10u, releaseHelper->getNumThreadsPerEu()); EXPECT_TRUE(releaseHelper->isRayTracingSupported()); EXPECT_EQ(0u, releaseHelper->getStackSizePerRay()); - EXPECT_EQ(revision == 0, releaseHelper->isDisablingMsaaRequired()); EXPECT_TRUE(releaseHelper->isNumRtStacksPerDssFixedValue()); EXPECT_TRUE(releaseHelper->getFtrXe2Compression()); } diff --git a/shared/test/unit_test/xe2_hpg_core/test_encode_xe2_hpg_core.cpp b/shared/test/unit_test/xe2_hpg_core/test_encode_xe2_hpg_core.cpp index 27a8b0058e..3cad89f9b2 100644 --- a/shared/test/unit_test/xe2_hpg_core/test_encode_xe2_hpg_core.cpp +++ b/shared/test/unit_test/xe2_hpg_core/test_encode_xe2_hpg_core.cpp @@ -624,11 +624,7 @@ XE2_HPG_CORETEST_F(EncodeKernelXe2HpgCoreTest, givenSurfaceStateAndAuxSurfaceMod auto originalAuxMode = surfaceState.getAuxiliarySurfaceMode(); EncodeSurfaceState::setAuxParamsForMCSCCS(&surfaceState, releaseHelper.get()); - if (releaseHelper->isDisablingMsaaRequired()) { - EXPECT_EQ(surfaceState.getAuxiliarySurfaceMode(), EncodeSurfaceState::AUXILIARY_SURFACE_MODE::AUXILIARY_SURFACE_MODE_AUX_NONE); - } else { - EXPECT_EQ(surfaceState.getAuxiliarySurfaceMode(), originalAuxMode); - } + EXPECT_EQ(surfaceState.getAuxiliarySurfaceMode(), originalAuxMode); } XE2_HPG_CORETEST_F(EncodeKernelXe2HpgCoreTest, givenSurfaceStateAndAuxSurfaceModeOverrideRequiredIsTrueWhenAuxParamsForMCSCCSAreSetThenCorrectAuxModeIsSet) { diff --git a/shared/test/unit_test/xe3_core/test_encode_xe3_core.cpp b/shared/test/unit_test/xe3_core/test_encode_xe3_core.cpp index dcde7f1a17..07dd61319a 100644 --- a/shared/test/unit_test/xe3_core/test_encode_xe3_core.cpp +++ b/shared/test/unit_test/xe3_core/test_encode_xe3_core.cpp @@ -565,25 +565,12 @@ XE3_CORETEST_F(EncodeKernelXe3CoreTest, givenCommandContainerWhenNumGrfRequiredI EXPECT_EQ(productHelper.isGrfNumReportedWithScm(), cmd->getLargeGrfMode()); } -XE3_CORETEST_F(CommandEncodeXe3CoreTest, givenSurfaceStateAndIsDisablingMsaaRequiredIsTrueWhenAuxParamsForMCSCCSAreSetThenCorrectAuxModeIsSet) { +XE3_CORETEST_F(CommandEncodeXe3CoreTest, givenSurfaceStateWhenAuxParamsForMCSCCSAreSetThenCorrectAuxModeIsSet) { auto surfaceState = FamilyType::cmdInitRenderSurfaceState; auto releaseHelper = std::make_unique(); - releaseHelper->isDisablingMsaaRequiredResult = true; - EncodeSurfaceState::setAuxParamsForMCSCCS(&surfaceState, releaseHelper.get()); - EXPECT_EQ(surfaceState.getAuxiliarySurfaceMode(), EncodeSurfaceState::AUXILIARY_SURFACE_MODE::AUXILIARY_SURFACE_MODE_AUX_NONE); -} - -XE3_CORETEST_F(CommandEncodeXe3CoreTest, givenSurfaceStateAndIsDisablingMsaaRequiredIsFalseWhenAuxParamsForMCSCCSAreSetThenCorrectAuxModeIsSet) { - auto surfaceState = FamilyType::cmdInitRenderSurfaceState; - auto originalAuxMode = surfaceState.getAuxiliarySurfaceMode(); - - auto releaseHelper = std::make_unique(); - releaseHelper->isDisablingMsaaRequiredResult = false; - - EncodeSurfaceState::setAuxParamsForMCSCCS(&surfaceState, releaseHelper.get()); - EXPECT_EQ(surfaceState.getAuxiliarySurfaceMode(), originalAuxMode); + EXPECT_EQ(surfaceState.getAuxiliarySurfaceMode(), EncodeSurfaceState::AUXILIARY_SURFACE_MODE::AUXILIARY_SURFACE_MODE_AUX_MCS); } using Xe3SbaTest = SbaTest;