Media/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-09-15 13:01:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix clang-tidy issues

Browse Source 
Change-Id: I18f6880f84524eb3ea704045dde1293d1a623f5d
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
This commit is contained in:
Mateusz Jablonski
2020-03-10 15:21:12 +01:00
committed by sys_ocldev
parent bbc2e68c92
commit ac0edb9a5d
5 changed files with 19 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
opencl/test/unit_test/command_queue/command_queue_fixture.h
View File

@ -41,9 +41,9 @@ struct CommandQueueHwFixture {
struct OOQueueFixture : public CommandQueueHwFixture {
typedef CommandQueueHwFixture BaseClass;
virtual void SetUp(ClDevice *_pDevice, cl_command_queue_properties _properties) override {
ASSERT_NE(nullptr, _pDevice);
BaseClass::pCmdQ = BaseClass::createCommandQueue(_pDevice, CL_QUEUE_OUT_OF_ORDER_EXEC_MODE_ENABLE);
void SetUp(ClDevice *pDevice, cl_command_queue_properties properties) override {
ASSERT_NE(nullptr, pDevice);
BaseClass::pCmdQ = BaseClass::createCommandQueue(pDevice, CL_QUEUE_OUT_OF_ORDER_EXEC_MODE_ENABLE);
ASSERT_NE(nullptr, BaseClass::pCmdQ);
}
};

2
opencl/test/unit_test/gen_common/gen_cmd_parse.h
View File

@ -92,7 +92,7 @@ struct CmdParse : public T {
static size_t getCommandLengthHwSpecific(void *cmd);
static size_t getAdditionalCommandLength(void *cmd);
static bool parseCommandBuffer(GenCmdList &_cmds, void *_buffer, size_t _length);
static bool parseCommandBuffer(GenCmdList &cmds, void *buffer, size_t length);
template <typename CmdType>
static void validateCommand(GenCmdList::iterator itorBegin, GenCmdList::iterator itorEnd);

36
opencl/test/unit_test/helpers/hw_parse.h
View File

@ -20,17 +20,7 @@
namespace NEO {
struct HardwareParse {
HardwareParse() : previousCS(nullptr),
startCS(0),
startCSRCS(0),
sizeUsed(0),
cmdInterfaceDescriptorData(nullptr),
cmdMediaInterfaceDescriptorLoad(nullptr),
cmdMediaVfeState(nullptr),
cmdPipelineSelect(nullptr),
cmdStateBaseAddress(nullptr),
cmdWalker(nullptr),
cmdGpgpuCsrBaseAddress(nullptr) {
HardwareParse() {
itorMediaInterfaceDescriptorLoad = cmdList.end();
itorMediaVfeState = cmdList.end();
itorPipelineSelect = cmdList.end();
@ -193,11 +183,11 @@ struct HardwareParse {
// The starting point of parsing commandBuffers. This is important
// because as buffers get reused, we only want to parse the deltas.
LinearStream *previousCS;
size_t startCS;
size_t startCSRCS;
LinearStream *previousCS = nullptr;
size_t startCS = 0u;
size_t startCSRCS = 0u;
size_t sizeUsed;
size_t sizeUsed = 0u;
GenCmdList cmdList;
GenCmdList lriList;
GenCmdList::iterator itorMediaInterfaceDescriptorLoad;
@ -208,14 +198,14 @@ struct HardwareParse {
GenCmdList::iterator itorBBStartAfterWalker;
GenCmdList::iterator itorGpgpuCsrBaseAddress;
void *cmdInterfaceDescriptorData;
void *cmdMediaInterfaceDescriptorLoad;
void *cmdMediaVfeState;
void *cmdPipelineSelect;
void *cmdStateBaseAddress;
void *cmdWalker;
void *cmdBBStartAfterWalker;
void *cmdGpgpuCsrBaseAddress;
void *cmdInterfaceDescriptorData = nullptr;
void *cmdMediaInterfaceDescriptorLoad = nullptr;
void *cmdMediaVfeState = nullptr;
void *cmdPipelineSelect = nullptr;
void *cmdStateBaseAddress = nullptr;
void *cmdWalker = nullptr;
void *cmdBBStartAfterWalker = nullptr;
void *cmdGpgpuCsrBaseAddress = nullptr;
};
} // namespace NEO

5
opencl/test/unit_test/libult/ult_command_stream_receiver.h
View File

@ -84,16 +84,13 @@ class UltCommandStreamReceiver : public CommandStreamReceiverHw<GfxFamily>, publ
using BaseClass::CommandStreamReceiver::timestampPacketWriteEnabled;
using BaseClass::CommandStreamReceiver::waitForTaskCountAndCleanAllocationList;
virtual ~UltCommandStreamReceiver() override {
}
UltCommandStreamReceiver(ExecutionEnvironment &executionEnvironment, uint32_t rootDeviceIndex) : BaseClass(executionEnvironment, rootDeviceIndex), recursiveLockCounter(0),
recordedDispatchFlags(DispatchFlagsHelper::createDefaultDispatchFlags()) {}
static CommandStreamReceiver *create(bool withAubDump, ExecutionEnvironment &executionEnvironment, uint32_t rootDeviceIndex) {
return new UltCommandStreamReceiver<GfxFamily>(executionEnvironment, rootDeviceIndex);
}
virtual GmmPageTableMngr *createPageTableManager() override {
GmmPageTableMngr *createPageTableManager() override {
createPageTableManagerCalled = true;
return nullptr;
}

2
opencl/test/unit_test/mocks/mock_aub_file_stream.h
View File

@ -46,7 +46,7 @@ struct MockAubFileStream : public AUBCommandStreamReceiver::AubFileStream {
lockStreamCalled = true;
return AUBCommandStreamReceiver::AubFileStream::lockStream();
}
void expectMMIO(uint32_t mmioRegister, uint32_t expectedValue) {
void expectMMIO(uint32_t mmioRegister, uint32_t expectedValue) override {
mmioRegisterFromExpectMMIO = mmioRegister;
expectedValueFromExpectMMIO = expectedValue;
}