Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: call isPrefetchDisablingRequired directly from release helper 

Related-To: NEO-7786
Signed-off-by: Kamil Kopryk <kamil.kopryk@intel.com>
This commit is contained in:
Kamil Kopryk 2023-06-05 13:36:06 +00:00 committed by Compute-Runtime-Automation
parent bc719ad80e
commit b092dd0cf2
7 changed files with 3 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
shared/source/os_interface/product_helper.h
View File

@ -114,7 +114,6 @@ class ProductHelper {
virtual bool imagePitchAlignmentWARequired(const HardwareInfo &hwInfo) const = 0; virtual bool imagePitchAlignmentWARequired(const HardwareInfo &hwInfo) const = 0;
virtual bool isForceEmuInt32DivRemSPWARequired(const HardwareInfo &hwInfo) const = 0; virtual bool isForceEmuInt32DivRemSPWARequired(const HardwareInfo &hwInfo) const = 0;
virtual bool is3DPipelineSelectWARequired() const = 0; virtual bool is3DPipelineSelectWARequired() const = 0;
virtual bool isPrefetchDisablingRequired(const ReleaseHelper *releaseHelper) const = 0;
virtual bool isStorageInfoAdjustmentRequired() const = 0; virtual bool isStorageInfoAdjustmentRequired() const = 0;
virtual bool isBlitterForImagesSupported() const = 0; virtual bool isBlitterForImagesSupported() const = 0;
virtual bool isPageFaultSupported() const = 0; virtual bool isPageFaultSupported() const = 0;

8
shared/source/os_interface/product_helper.inl
View File

@ -277,14 +277,6 @@ bool ProductHelperHw<gfxProduct>::isAllocationSizeAdjustmentRequired(const Hardw
return false; return false;
} }
template <PRODUCT_FAMILY gfxProduct>
bool ProductHelperHw<gfxProduct>::isPrefetchDisablingRequired(const ReleaseHelper *releaseHelper) const {
if (releaseHelper) {
return releaseHelper->isPrefetchDisablingRequired();
}
return false;
}
template <PRODUCT_FAMILY gfxProduct> template <PRODUCT_FAMILY gfxProduct>
bool ProductHelperHw<gfxProduct>::isAssignEngineRoundRobinSupported() const { bool ProductHelperHw<gfxProduct>::isAssignEngineRoundRobinSupported() const {
return false; return false;

1
shared/source/os_interface/product_helper_hw.h
View File

@ -68,7 +68,6 @@ class ProductHelperHw : public ProductHelper {
bool isForceEmuInt32DivRemSPWARequired(const HardwareInfo &hwInfo) const override; bool isForceEmuInt32DivRemSPWARequired(const HardwareInfo &hwInfo) const override;
bool is3DPipelineSelectWARequired() const override; bool is3DPipelineSelectWARequired() const override;
bool isStorageInfoAdjustmentRequired() const override; bool isStorageInfoAdjustmentRequired() const override;
bool isPrefetchDisablingRequired(const ReleaseHelper *releaseHelper) const override;
bool isBlitterForImagesSupported() const override; bool isBlitterForImagesSupported() const override;
bool isPageFaultSupported() const override; bool isPageFaultSupported() const override;
bool isKmdMigrationSupported() const override; bool isKmdMigrationSupported() const override;

3
shared/source/xe_hpg_core/command_encoder_xe_hpg_core.cpp
View File

@ -119,9 +119,8 @@ void EncodeDispatchKernel<Family>::programBarrierEnable(INTERFACE_DESCRIPTOR_DAT
template <> template <>
void EncodeDispatchKernel<Family>::encodeAdditionalWalkerFields(const RootDeviceEnvironment &rootDeviceEnvironment, WALKER_TYPE &walkerCmd, const EncodeWalkerArgs &walkerArgs) { void EncodeDispatchKernel<Family>::encodeAdditionalWalkerFields(const RootDeviceEnvironment &rootDeviceEnvironment, WALKER_TYPE &walkerCmd, const EncodeWalkerArgs &walkerArgs) {
auto &productHelper = rootDeviceEnvironment.getHelper<ProductHelper>();
auto *releaseHelper = rootDeviceEnvironment.getReleaseHelper(); auto *releaseHelper = rootDeviceEnvironment.getReleaseHelper();
bool l3PrefetchDisable = productHelper.isPrefetchDisablingRequired(releaseHelper); bool l3PrefetchDisable = releaseHelper->isPrefetchDisablingRequired();
int32_t overrideL3PrefetchDisable = DebugManager.flags.ForceL3PrefetchForComputeWalker.get(); int32_t overrideL3PrefetchDisable = DebugManager.flags.ForceL3PrefetchForComputeWalker.get();
if (overrideL3PrefetchDisable != -1) { if (overrideL3PrefetchDisable != -1) {
l3PrefetchDisable = !overrideL3PrefetchDisable; l3PrefetchDisable = !overrideL3PrefetchDisable;

5
shared/test/common/mocks/mock_product_helper.cpp
View File

@ -185,11 +185,6 @@ bool ProductHelperHw<IGFX_UNKNOWN>::isAllocationSizeAdjustmentRequired(const Har
return false; return false;
} }
template <>
bool ProductHelperHw<IGFX_UNKNOWN>::isPrefetchDisablingRequired(const ReleaseHelper *releaseHelper) const {
return false;
}
template <> template <>
bool ProductHelperHw<IGFX_UNKNOWN>::isNewResidencyModelSupported() const { bool ProductHelperHw<IGFX_UNKNOWN>::isNewResidencyModelSupported() const {
return false; return false;

5
shared/test/unit_test/os_interface/product_helper_tests.cpp
View File

@ -328,11 +328,6 @@ HWTEST_F(ProductHelperTest, WhenCheckAssignEngineRoundRobinSupportedThenReturnFa
EXPECT_FALSE(productHelper->isAssignEngineRoundRobinSupported()); EXPECT_FALSE(productHelper->isAssignEngineRoundRobinSupported());
} }
HWTEST_F(ProductHelperTest, givenProductHelperWhenAskedIfPrefetchDisablingIsRequiredThenFalseIsReturned) {
EXPECT_FALSE(productHelper->isPrefetchDisablingRequired(releaseHelper));
}
HWTEST_F(ProductHelperTest, givenProductHelperWhenAskedIfPipeControlPriorToNonPipelinedStateCommandsWARequiredThenFalseIsReturned) { HWTEST_F(ProductHelperTest, givenProductHelperWhenAskedIfPipeControlPriorToNonPipelinedStateCommandsWARequiredThenFalseIsReturned) {
auto isRcs = false; auto isRcs = false;

3
shared/test/unit_test/xe_hpg_core/dg2/product_config_helper_tests_dg2.cpp
View File

@ -13,6 +13,7 @@
#include "shared/source/helpers/gfx_core_helper.h" #include "shared/source/helpers/gfx_core_helper.h"
#include "shared/source/helpers/product_config_helper.h" #include "shared/source/helpers/product_config_helper.h"
#include "shared/source/os_interface/product_helper.h" #include "shared/source/os_interface/product_helper.h"
#include "shared/source/release_helper/release_helper.h"
#include "shared/source/xe_hpg_core/hw_cmds_dg2.h" #include "shared/source/xe_hpg_core/hw_cmds_dg2.h"
#include "shared/test/common/fixtures/device_fixture.h" #include "shared/test/common/fixtures/device_fixture.h"
#include "shared/test/common/helpers/debug_manager_state_restore.h" #include "shared/test/common/helpers/debug_manager_state_restore.h"
@ -293,7 +294,7 @@ DG2TEST_F(ProductHelperTestDg2, givenDg2G10A0OrA1SteppingWhenAskingIfWAIsRequire
EXPECT_EQ(expectedValue, productHelper->isDefaultEngineTypeAdjustmentRequired(hwInfo)); EXPECT_EQ(expectedValue, productHelper->isDefaultEngineTypeAdjustmentRequired(hwInfo));
EXPECT_EQ(expectedValue, productHelper->isAllocationSizeAdjustmentRequired(hwInfo)); EXPECT_EQ(expectedValue, productHelper->isAllocationSizeAdjustmentRequired(hwInfo));
EXPECT_EQ(expectedValue, productHelper->isPrefetchDisablingRequired(releaseHelper)); EXPECT_EQ(expectedValue, releaseHelper->isPrefetchDisablingRequired());
} }
} }