Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor: add event residency parameter to command list append kernel call 

Related-To: NEO-10064

Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
This commit is contained in:
Zbigniew Zdanowicz 2024-02-20 09:46:20 +00:00 committed by Compute-Runtime-Automation
parent b7ef6d1e07
commit ca8406f97e
3 changed files with 42 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
level_zero/core/source/cmdlist/cmdlist_hw_xehp_and_later.inl
View File

@ -201,7 +201,9 @@ ze_result_t CommandListCoreFamily<gfxCoreFamily>::appendLaunchKernelWithParams(K
NEO::GraphicsAllocation *eventPoolAlloc = event->getPoolAllocation(this->device);
if (eventPoolAlloc) {
commandContainer.addToResidencyContainer(eventPoolAlloc);
if (!launchParams.omitAddingEventResidency) {
commandContainer.addToResidencyContainer(eventPoolAlloc);
}
eventAddress = event->getPacketAddress(this->device);
isTimestampEvent = event->isUsingContextEndOffset();
}

1
level_zero/core/source/cmdlist/cmdlist_launch_params.h
View File

@ -29,5 +29,6 @@ struct CmdListKernelLaunchParams {
bool skipInOrderNonWalkerSignaling = false;
bool pipeControlSignalling = false;
bool omitAddingKernelResidency = false;
bool omitAddingEventResidency = false;
};
} // namespace L0

38
level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_append_launch_kernel_1.cpp
View File

@ -1508,5 +1508,43 @@ HWTEST2_F(CommandListAppendLaunchKernelMockModule,
EXPECT_EQ(*itorWalker, launchParams.outWalker);
}
HWTEST2_F(CommandListAppendLaunchKernelMockModule,
givenFlagOmitEventResourcePassToCmdlistResidencyWhenAppendingKernelThenExpectNoEventInCmdlistResidency,
IsAtLeastXeHpCore) {
ze_result_t returnValue;
ze_event_pool_desc_t eventPoolDesc = {ZE_STRUCTURE_TYPE_EVENT_POOL_DESC};
eventPoolDesc.count = 1;
std::unique_ptr<L0::EventPool> eventPool(EventPool::create(driverHandle.get(), context, 0, nullptr, &eventPoolDesc, returnValue));
EXPECT_EQ(ZE_RESULT_SUCCESS, returnValue);
ze_event_desc_t eventDesc = {ZE_STRUCTURE_TYPE_EVENT_DESC};
ze_event_handle_t event = nullptr;
ASSERT_EQ(ZE_RESULT_SUCCESS, eventPool->createEvent(&eventDesc, &event));
std::unique_ptr<L0::Event> eventObject(L0::Event::fromHandle(event));
auto eventAllocation = eventObject->getPoolAllocation(device);
ASSERT_NE(nullptr, eventAllocation);
ze_group_count_t groupCount{1, 1, 1};
CmdListKernelLaunchParams launchParams = {};
launchParams.omitAddingEventResidency = true;
returnValue = commandList->appendLaunchKernel(kernel->toHandle(), groupCount, event, 0, nullptr, launchParams, false);
ASSERT_EQ(ZE_RESULT_SUCCESS, returnValue);
auto &cmdlistResidency = commandList->getCmdContainer().getResidencyContainer();
auto eventAllocationIt = std::find(cmdlistResidency.begin(), cmdlistResidency.end(), eventAllocation);
EXPECT_EQ(eventAllocationIt, cmdlistResidency.end());
launchParams.omitAddingEventResidency = false;
returnValue = commandList->appendLaunchKernel(kernel->toHandle(), groupCount, event, 0, nullptr, launchParams, false);
ASSERT_EQ(ZE_RESULT_SUCCESS, returnValue);
eventAllocationIt = std::find(cmdlistResidency.begin(), cmdlistResidency.end(), eventAllocation);
EXPECT_NE(eventAllocationIt, cmdlistResidency.end());
}
} // namespace ult
} // namespace L0