Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use memcpy for getting and setting event values 

Direct pointer dereference may not yield expected results

Change-Id: I872dd837ae21bc8a0e1833527cc9a8791cad5295
Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@intel.com>
This commit is contained in:
Aravind Gopalakrishnan 2020-05-07 16:02:30 -07:00
parent bd31c15382
commit d176462fb0
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
level_zero/core/source/event/event.cpp
View File

@ -40,6 +40,8 @@ struct EventImp : public Event {
ze_result_t queryStatus() override {
uint64_t *hostAddr = static_cast<uint64_t *>(hostAddress);
uint32_t queryVal = Event::STATE_CLEARED;
auto alloc = &(this->eventPool->getAllocation());
if (metricTracer != nullptr) {
@ -55,7 +57,9 @@ struct EventImp : public Event {
hostAddr = reinterpret_cast<uint64_t *>(timeStampAddress);
}
return *hostAddr == Event::STATE_CLEARED ? ZE_RESULT_NOT_READY : ZE_RESULT_SUCCESS;
memcpy_s(static_cast<void *>(&queryVal), sizeof(uint32_t), static_cast<void *>(hostAddr), sizeof(uint32_t));
return queryVal == Event::STATE_CLEARED ? ZE_RESULT_NOT_READY : ZE_RESULT_SUCCESS;
}
ze_result_t reset() override;
@ -244,7 +248,7 @@ ze_result_t EventImp::hostEventSetValue(uint32_t eventVal) {
auto hostAddr = static_cast<uint64_t *>(hostAddress);
UNRECOVERABLE_IF(hostAddr == nullptr);
*(hostAddr) = eventVal;
memcpy_s(static_cast<void *>(hostAddr), sizeof(uint32_t), static_cast<void *>(&eventVal), sizeof(uint32_t));
makeAllocationResident();