From d52330b5aa5876a843bc8e8d9339dfa0cf2e9bb2 Mon Sep 17 00:00:00 2001 From: Kamil Kopryk Date: Mon, 29 Jul 2024 13:46:47 +0000 Subject: [PATCH] test: use walkerVariant in ults 7/n Related-To: NEO-10641 Signed-off-by: Kamil Kopryk --- .../dispatch_walker_tests_dg2_and_later.cpp | 23 +++++++++++-------- .../dispatch_walker_tests_xehp_and_later.cpp | 16 +++++++++---- 2 files changed, 25 insertions(+), 14 deletions(-) diff --git a/opencl/test/unit_test/command_queue/dispatch_walker_tests_dg2_and_later.cpp b/opencl/test/unit_test/command_queue/dispatch_walker_tests_dg2_and_later.cpp index e0df77e48c..2bffa7a486 100644 --- a/opencl/test/unit_test/command_queue/dispatch_walker_tests_dg2_and_later.cpp +++ b/opencl/test/unit_test/command_queue/dispatch_walker_tests_dg2_and_later.cpp @@ -183,7 +183,8 @@ HWTEST2_F(Dg2AndLaterDispatchWalkerBasicTest, givenDebugFlagToDisableL1FlushInPo } HWTEST2_F(Dg2AndLaterDispatchWalkerBasicTest, givenDebugVariableEnabledWhenEnqueueingThenWriteWalkerStamp, matcherDG2AndLater) { - using DefaultWalkerType = typename FamilyType::DefaultWalkerType; + using WalkerVariant = typename FamilyType::WalkerVariant; + DebugManagerStateRestore restore; debugManager.flags.EnableTimestampPacket.set(true); @@ -201,15 +202,19 @@ HWTEST2_F(Dg2AndLaterDispatchWalkerBasicTest, givenDebugVariableEnabledWhenEnque hwParser.findHardwareCommands(); EXPECT_NE(hwParser.itorWalker, hwParser.cmdList.end()); - auto walker = genCmdCast(*hwParser.itorWalker); - auto gmmHelper = device->getGmmHelper(); auto expectedMocs = MemorySynchronizationCommands::getDcFlushEnable(true, device->getRootDeviceEnvironment()) ? gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER_CACHELINE_MISALIGNED) : gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER); - auto &postSyncData = walker->getPostSync(); - EXPECT_EQ(FamilyType::POSTSYNC_DATA::OPERATION::OPERATION_WRITE_TIMESTAMP, - postSyncData.getOperation()); - EXPECT_TRUE(postSyncData.getDataportPipelineFlush()); - EXPECT_TRUE(postSyncData.getDataportSubsliceCacheFlush()); - EXPECT_EQ(expectedMocs, postSyncData.getMocs()); + WalkerVariant walkerVariant = NEO::UnitTestHelper::getWalkerVariant(*hwParser.itorWalker); + + std::visit([expectedMocs](auto &&walker) { + auto &postSyncData = walker->getPostSync(); + using PostSyncType = std::decay_t; + + EXPECT_EQ(PostSyncType::OPERATION::OPERATION_WRITE_TIMESTAMP, postSyncData.getOperation()); + EXPECT_TRUE(postSyncData.getDataportPipelineFlush()); + EXPECT_TRUE(postSyncData.getDataportSubsliceCacheFlush()); + EXPECT_EQ(expectedMocs, postSyncData.getMocs()); + }, + walkerVariant); } diff --git a/opencl/test/unit_test/command_queue/dispatch_walker_tests_xehp_and_later.cpp b/opencl/test/unit_test/command_queue/dispatch_walker_tests_xehp_and_later.cpp index 242cdd80e1..2e7a54c7dd 100644 --- a/opencl/test/unit_test/command_queue/dispatch_walker_tests_xehp_and_later.cpp +++ b/opencl/test/unit_test/command_queue/dispatch_walker_tests_xehp_and_later.cpp @@ -1696,6 +1696,9 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTestStaticPartition, using NonDefaultPlatformGpuWalkerTest = XeHPAndLaterDispatchWalkerBasicTest; HWCMDTEST_F(IGFX_XE_HP_CORE, NonDefaultPlatformGpuWalkerTest, givenNonDefaultPlatformWhenSetupTimestampPacketThenGmmHelperIsTakenFromNonDefaultPlatform) { + + using WalkerVariant = typename FamilyType::WalkerVariant; + auto executionEnvironment = std::make_unique(); auto rootDeviceEnvironment = executionEnvironment->rootDeviceEnvironments[0].get(); rootDeviceEnvironment->initGmm(); @@ -1706,12 +1709,15 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, NonDefaultPlatformGpuWalkerTest, givenNonDefaultPla TagNode> timestamp; ClHardwareParse hwParser; hwParser.parseCommands(*cmdQ); - auto computeWalker = reinterpret_cast(hwParser.cmdWalker); - ASSERT_NE(nullptr, computeWalker); - platformsImpl->clear(); - EXPECT_EQ(platform(), nullptr); - GpgpuWalkerHelper::setupTimestampPacket(&cmdStream, computeWalker, static_cast(×tamp), *rootDeviceEnvironment); + WalkerVariant walkerVariant = NEO::UnitTestHelper::getWalkerVariant(hwParser.cmdWalker); + std::visit([&](auto &&walker) { + ASSERT_NE(nullptr, walker); + platformsImpl->clear(); + EXPECT_EQ(platform(), nullptr); + GpgpuWalkerHelper::setupTimestampPacket(&cmdStream, walker, static_cast(×tamp), *rootDeviceEnvironment); + }, + walkerVariant); } HWCMDTEST_F(IGFX_XE_HP_CORE, WalkerDispatchTest, givenDefaultLocalIdsGenerationWhenPassingFittingParametersThenReturnFalse) {