Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor: remove inactive code 

- verifyDebugCapabilities() did not fail build when debug_env did not have
systemThreadSurfaceAddress defined

Signed-off-by: Mateusz Hoppe <mateusz.hoppe@intel.com>
This commit is contained in:
Mateusz Hoppe 2024-10-04 09:26:45 +00:00 committed by Compute-Runtime-Automation
parent be295ef9a0
commit e240dca7cd
2 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
level_zero/core/source/module/module_imp.cpp
View File

@ -545,7 +545,7 @@ ze_result_t ModuleImp::initialize(const ze_module_desc_t *desc, NEO::Device *neo
if (result != ZE_RESULT_SUCCESS) {
return result;
}
this->verifyDebugCapabilities();
if (this->shouldBuildBeFailed(neoDevice)) {
return ZE_RESULT_ERROR_MODULE_BUILD_FAILURE;
}
@ -1279,20 +1279,6 @@ ze_result_t ModuleImp::getKernelNames(uint32_t *pCount, const char **pNames) {
return ZE_RESULT_SUCCESS;
}
void ModuleImp::verifyDebugCapabilities() {
bool debugCapabilities = device->getNEODevice()->getDebugger() != nullptr;
if (debugCapabilities) {
// verify all kernels are debuggable
for (auto kernelInfo : this->translationUnit->programInfo.kernelInfos) {
bool systemThreadSurfaceAvailable = NEO::isValidOffset(kernelInfo->kernelDescriptor.payloadMappings.implicitArgs.systemThreadSurfaceAddress.bindful) ||
NEO::isValidOffset(kernelInfo->kernelDescriptor.payloadMappings.implicitArgs.systemThreadSurfaceAddress.bindless);
debugCapabilities &= systemThreadSurfaceAvailable;
}
}
}
void ModuleImp::checkIfPrivateMemoryPerDispatchIsNeeded() {
size_t modulePrivateMemorySize = 0;
auto neoDevice = this->device->getNEODevice();

1
level_zero/core/source/module/module_imp.h
View File

@ -170,7 +170,6 @@ struct ModuleImp : public Module {
ze_result_t allocateKernelImmutableDatas(size_t kernelsCount);
ze_result_t initializeKernelImmutableDatas();
void copyPatchedSegments(const NEO::Linker::PatchableSegments &isaSegmentsForPatching);
void verifyDebugCapabilities();
void checkIfPrivateMemoryPerDispatchIsNeeded() override;
NEO::Zebin::Debug::Segments getZebinSegments();
void createDebugZebin();