From efbfd5c38707e308b50b8b217e11ae42c2b47e96 Mon Sep 17 00:00:00 2001 From: Adam Cetnerowski Date: Mon, 12 Apr 2021 10:28:06 +0200 Subject: [PATCH] ULT renaming: Read Buffer tests Related-To: NEO-2236 Signed-off-by: Adam Cetnerowski --- .../enqueue_read_buffer_tests.cpp | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/opencl/test/unit_test/command_queue/enqueue_read_buffer_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_read_buffer_tests.cpp index 064ae6522d..c16f0b6afd 100644 --- a/opencl/test/unit_test/command_queue/enqueue_read_buffer_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_read_buffer_tests.cpp @@ -26,7 +26,7 @@ using namespace NEO; -HWTEST_F(EnqueueReadBufferTypeTest, null_mem_object) { +HWTEST_F(EnqueueReadBufferTypeTest, GivenNullBufferWhenReadingBufferThenInvalidMemObjectErrorIsReturned) { auto data = 1; auto retVal = clEnqueueReadBuffer( pCmdQ, @@ -42,7 +42,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, null_mem_object) { EXPECT_EQ(CL_INVALID_MEM_OBJECT, retVal); } -HWTEST_F(EnqueueReadBufferTypeTest, null_user_pointer) { +HWTEST_F(EnqueueReadBufferTypeTest, GivenNullUserPointerWhenReadingBufferThenInvalidValueErrorIsReturned) { auto data = 1; auto retVal = clEnqueueReadBuffer( @@ -59,7 +59,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, null_user_pointer) { EXPECT_EQ(CL_INVALID_VALUE, retVal); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, GPGPUWalker) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, WhenReadingBufferThenGpgpuWalkerIsProgrammedCorrectly) { typedef typename FamilyType::GPGPU_WALKER GPGPU_WALKER; srcBuffer->forceDisallowCPUCopy = true; @@ -93,7 +93,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, GPGPUWalker) { } } -HWTEST_F(EnqueueReadBufferTypeTest, bumpsTaskLevel) { +HWTEST_F(EnqueueReadBufferTypeTest, WhenReadingBufferThenTaskLevelIsIncremented) { auto taskLevelBefore = pCmdQ->taskLevel; srcBuffer->forceDisallowCPUCopy = true; @@ -101,7 +101,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, bumpsTaskLevel) { EXPECT_GT(pCmdQ->taskLevel, taskLevelBefore); } -HWTEST_F(EnqueueReadBufferTypeTest, alignsToCSR_Blocking) { +HWTEST_F(EnqueueReadBufferTypeTest, GivenBlockingWhenReadingBufferThenAlignedToCsr) { //this test case assumes IOQ auto &csr = pDevice->getUltCommandStreamReceiver(); csr.taskCount = pCmdQ->taskCount + 100; @@ -114,7 +114,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, alignsToCSR_Blocking) { EXPECT_EQ(oldCsrTaskLevel, pCmdQ->taskLevel); } -HWTEST_F(EnqueueReadBufferTypeTest, alignsToCSR_NonBlocking) { +HWTEST_F(EnqueueReadBufferTypeTest, GivenNonBlockingWhenReadingBufferThenAlignedToCsr) { //this test case assumes IOQ auto &csr = pDevice->getUltCommandStreamReceiver(); csr.taskCount = pCmdQ->taskCount + 100; @@ -125,7 +125,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, alignsToCSR_NonBlocking) { EXPECT_EQ(csr.peekTaskLevel(), pCmdQ->taskLevel + 1); } -HWTEST_F(EnqueueReadBufferTypeTest, addsCommands) { +HWTEST_F(EnqueueReadBufferTypeTest, WhenReadingBufferThenCommandsAreAdded) { auto usedCmdBufferBefore = pCS->getUsed(); srcBuffer->forceDisallowCPUCopy = true; @@ -133,7 +133,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, addsCommands) { EXPECT_NE(usedCmdBufferBefore, pCS->getUsed()); } -HWTEST_F(EnqueueReadBufferTypeTest, addsIndirectData) { +HWTEST_F(EnqueueReadBufferTypeTest, WhenReadingBufferThenIndirectDataIsAdded) { auto dshBefore = pDSH->getUsed(); auto iohBefore = pIOH->getUsed(); auto sshBefore = pSSH->getUsed(); @@ -165,7 +165,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, addsIndirectData) { } } -HWTEST_F(EnqueueReadBufferTypeTest, LoadRegisterImmediateL3CNTLREG) { +HWTEST_F(EnqueueReadBufferTypeTest, WhenReadingBufferThenLoadRegisterImmediateL3CntlregIsCorrect) { srcBuffer->forceDisallowCPUCopy = true; enqueueReadBuffer(); validateL3Programming(cmdList, itorWalker); @@ -183,7 +183,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, WhenEnqueueIsDoneThenStat pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, MediaInterfaceDescriptorLoad) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, WhenReadingBufferThenMediaInterfaceDescriptorLoadIsCorrect) { typedef typename FamilyType::MEDIA_INTERFACE_DESCRIPTOR_LOAD MEDIA_INTERFACE_DESCRIPTOR_LOAD; typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA; @@ -212,7 +212,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, MediaInterfaceDescriptorL FamilyType::PARSE::template validateCommand(cmdList.begin(), itorCmd); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, InterfaceDescriptorData) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, WhenReadingBufferThenInterfaceDescriptorDataIsCorrect) { typedef typename FamilyType::MEDIA_INTERFACE_DESCRIPTOR_LOAD MEDIA_INTERFACE_DESCRIPTOR_LOAD; typedef typename FamilyType::STATE_BASE_ADDRESS STATE_BASE_ADDRESS; typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA; @@ -250,20 +250,20 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, InterfaceDescriptorData) EXPECT_NE(0u, IDD.getConstantIndirectUrbEntryReadLength()); } -HWTEST_F(EnqueueReadBufferTypeTest, PipelineSelect) { +HWTEST_F(EnqueueReadBufferTypeTest, WhenReadingBufferThenPipelineSelectIsProgrammedOnce) { srcBuffer->forceDisallowCPUCopy = true; enqueueReadBuffer(); int numCommands = getNumberOfPipelineSelectsThatEnablePipelineSelect(); EXPECT_EQ(1, numCommands); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, MediaVFEState) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, WhenReadingBufferThenMediaVfeStateIsCorrect) { srcBuffer->forceDisallowCPUCopy = true; enqueueReadBuffer(); validateMediaVFEState(&pDevice->getHardwareInfo(), cmdMediaVfeState, cmdList, itorMediaVfeState); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, blockingRequiresPipeControlAfterWalkerWithDCFlushSet) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, GivenBlockingWhenReadingBufferThenPipeControlAfterWalkerWithDcFlushSetIsAdded) { typedef typename FamilyType::PIPE_CONTROL PIPE_CONTROL; srcBuffer->forceDisallowCPUCopy = true; @@ -604,7 +604,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, givenForcedCpuCopyWhenEnqueueReadCompressedB EXPECT_TRUE(mockCmdQ->cpuDataTransferHandlerCalled); } -HWTEST_F(EnqueueReadBufferTypeTest, gicenEnqueueReadBufferCalledWhenLockedPtrInTransferPropertisIsNotAvailableThenItIsNotUnlocked) { +HWTEST_F(EnqueueReadBufferTypeTest, givenEnqueueReadBufferCalledWhenLockedPtrInTransferPropertisIsNotAvailableThenItIsNotUnlocked) { DebugManagerStateRestore dbgRestore; DebugManager.flags.DoCpuCopyOnReadBuffer.set(1);