From f29dc33b34cbeb530818d2fe92dda7d79ed5d283 Mon Sep 17 00:00:00 2001 From: Pawel Cieslak Date: Mon, 30 Oct 2023 16:56:03 +0000 Subject: [PATCH] fix: fix issues detected with clang-tidy-16 Signed-off-by: Pawel Cieslak --- .../core/test/unit_tests/sources/device/test_l0_device.cpp | 2 ++ .../unit_tests/sources/linux/nl_api/mock_nl_api_prelim.cpp | 4 ++-- .../sources/sysman/linux/nl_api/mock_nl_api_prelim.cpp | 4 ++-- opencl/test/unit_test/gtpin/gtpin_tests.cpp | 1 + 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/level_zero/core/test/unit_tests/sources/device/test_l0_device.cpp b/level_zero/core/test/unit_tests/sources/device/test_l0_device.cpp index 443e722b4f..90fcf6b0ac 100644 --- a/level_zero/core/test/unit_tests/sources/device/test_l0_device.cpp +++ b/level_zero/core/test/unit_tests/sources/device/test_l0_device.cpp @@ -3187,6 +3187,8 @@ TEST_F(MultipleDevicesTest, givenTopologyForTwoSubdevicesWhenGettingPhysicalSlic mapping.sliceIndices[i] = i; } + ASSERT_NE(0u, hwInfo.gtSystemInfo.SliceCount); + mapping.subsliceIndices.resize(hwInfo.gtSystemInfo.SubSliceCount / hwInfo.gtSystemInfo.SliceCount); for (uint32_t i = 0; i < hwInfo.gtSystemInfo.SubSliceCount / hwInfo.gtSystemInfo.SliceCount; i++) { mapping.subsliceIndices[i] = i; diff --git a/level_zero/sysman/test/unit_tests/sources/linux/nl_api/mock_nl_api_prelim.cpp b/level_zero/sysman/test/unit_tests/sources/linux/nl_api/mock_nl_api_prelim.cpp index ff0f96ab5d..4bc7e7f017 100644 --- a/level_zero/sysman/test/unit_tests/sources/linux/nl_api/mock_nl_api_prelim.cpp +++ b/level_zero/sysman/test/unit_tests/sources/linux/nl_api/mock_nl_api_prelim.cpp @@ -107,8 +107,8 @@ int MockNlApi::genlHandleMsg(struct nl_msg *msg, void *arg) { MyNlattr *head = new MyNlattr; MyNlattr *next = head; - info.attrs = new struct nlattr *[pOps->o_cmds[cmdIndex].c_maxattr]; - for (auto i = 0; i < pOps->o_cmds[cmdIndex].c_maxattr; i++) { + info.attrs = new struct nlattr *[_IAF_ATTR_COUNT]; + for (auto i = 0; i < _IAF_ATTR_COUNT; i++) { info.attrs[i] = nullptr; } next = addDefaultAttribs(info, next); diff --git a/level_zero/tools/test/unit_tests/sources/sysman/linux/nl_api/mock_nl_api_prelim.cpp b/level_zero/tools/test/unit_tests/sources/sysman/linux/nl_api/mock_nl_api_prelim.cpp index 3f85631a45..ab5e06cd40 100644 --- a/level_zero/tools/test/unit_tests/sources/sysman/linux/nl_api/mock_nl_api_prelim.cpp +++ b/level_zero/tools/test/unit_tests/sources/sysman/linux/nl_api/mock_nl_api_prelim.cpp @@ -106,8 +106,8 @@ int MockNlApi::genlHandleMsg(struct nl_msg *msg, void *arg) { MyNlattr *head = new MyNlattr; MyNlattr *next = head; - info.attrs = new struct nlattr *[pOps->o_cmds[cmdIndex].c_maxattr]; - for (auto i = 0; i < pOps->o_cmds[cmdIndex].c_maxattr; i++) { + info.attrs = new struct nlattr *[_IAF_ATTR_COUNT]; + for (auto i = 0; i < _IAF_ATTR_COUNT; i++) { info.attrs[i] = nullptr; } next = addDefaultAttribs(info, next); diff --git a/opencl/test/unit_test/gtpin/gtpin_tests.cpp b/opencl/test/unit_test/gtpin/gtpin_tests.cpp index 099bef302f..d333a4ba0e 100644 --- a/opencl/test/unit_test/gtpin/gtpin_tests.cpp +++ b/opencl/test/unit_test/gtpin/gtpin_tests.cpp @@ -421,6 +421,7 @@ TEST_F(GTPinTests, givenInvalidArgumentsThenBufferUnMapFails) { EXPECT_EQ(&NEO::gtpinFreeBuffer, driverServices.bufferDeallocate); EXPECT_EQ(&NEO::gtpinMapBuffer, driverServices.bufferMap); ASSERT_EQ(&NEO::gtpinUnmapBuffer, driverServices.bufferUnMap); + ASSERT_NE(nullptr, driverServices.bufferUnMap); retFromGtPin = (*driverServices.bufferUnMap)(nullptr, nullptr); EXPECT_NE(GTPIN_DI_SUCCESS, retFromGtPin);