Media/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-09-15 13:01:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use unique_ptr in tests of surface

Browse Source 
This change removes manual memory management via new/delete
and replaces it with std::unique_ptr.

Signed-off-by: Patryk Wrobel <patryk.wrobel@intel.com>
This commit is contained in:
Patryk Wrobel
2022-08-22 22:36:52 +00:00
committed by Compute-Runtime-Automation
parent 5584c1fe7a
commit f7925b9f15
2 changed files with 16 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
opencl/test/unit_test/memory_manager/mem_obj_surface_tests.cpp
View File

@ -19,7 +19,7 @@
#include "gtest/gtest.h"
#include <type_traits>
#include <memory>
using namespace NEO;
@ -48,20 +48,17 @@ HWTEST_F(SurfaceTest, GivenSurfaceWhenInterfaceIsUsedThenSurfaceBehavesCorrectly
auto osContext = executionEnvironment->memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(engine, PreemptionHelper::getDefaultPreemptionMode(hwInfo)));
csr->setupContext(*osContext);
Surface *surface = createSurface::create(this->data,
&this->buffer,
&this->gfxAllocation);
ASSERT_NE(nullptr, surface); // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
std::unique_ptr<Surface> surface{createSurface::create(this->data,
&this->buffer,
&this->gfxAllocation)};
ASSERT_NE(nullptr, surface);
Surface *duplicatedSurface = surface->duplicate();
ASSERT_NE(nullptr, duplicatedSurface); // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
std::unique_ptr<Surface> duplicatedSurface{surface->duplicate()};
ASSERT_NE(nullptr, duplicatedSurface);
surface->makeResident(*csr);
EXPECT_EQ(1u, csr->madeResidentGfxAllocations.size());
delete duplicatedSurface;
delete surface;
}
class CoherentMemObjSurface : public SurfaceTest {
@ -72,11 +69,8 @@ class CoherentMemObjSurface : public SurfaceTest {
};
TEST_F(CoherentMemObjSurface, GivenCoherentMemObjWhenCreatingSurfaceFromMemObjThenSurfaceIsCoherent) {
Surface *surface = createSurface::create(this->data,
&this->buffer,
&this->gfxAllocation);
std::unique_ptr<Surface> surface{createSurface::create(this->data,
&this->buffer,
&this->gfxAllocation)};
EXPECT_TRUE(surface->IsCoherent);
delete surface;
}