Media
/
compute-runtime
mirror of https://github.com/intel/compute-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

performance: enable new dispatch monitor fence policy in direct submission 

Related-To: NEO-8395

Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
This commit is contained in:
Zbigniew Zdanowicz 2023-11-28 14:55:36 +00:00 committed by Compute-Runtime-Automation
parent add635a605
commit fdcf7f6793
3 changed files with 73 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
shared/source/direct_submission/direct_submission_hw.h
View File

@ -246,6 +246,6 @@ class DirectSubmissionHw {
bool relaxedOrderingEnabled = false;
bool relaxedOrderingInitialized = false;
bool relaxedOrderingSchedulerRequired = false;
bool inputMonitorFenceDispatchRequirement = false;
bool inputMonitorFenceDispatchRequirement = true;
};
} // namespace NEO

4
shared/test/unit_test/direct_submission/linux/drm_direct_submission_tests.cpp
View File

@ -943,9 +943,9 @@ HWTEST_F(DrmDirectSubmissionTest, givenDrmDirectSubmissionWhenEnableRingSwitchTa
EXPECT_EQ(drmDirectSubmission.ringBuffers[prevRingBufferIndex].completionFence, newCompletionFenceValue + 1);
}
HWTEST_F(DrmDirectSubmissionTest, givenDrmDirectSubmissionWhenGettingDefaultInputMonitorFencePolicyThenDefaultIsFalse) {
HWTEST_F(DrmDirectSubmissionTest, givenDrmDirectSubmissionWhenGettingDefaultInputMonitorFencePolicyThenDefaultIsTrue) {
MockDrmDirectSubmission<FamilyType, RenderDispatcher<FamilyType>> drmDirectSubmission(*device->getDefaultEngine().commandStreamReceiver);
EXPECT_FALSE(drmDirectSubmission.inputMonitorFenceDispatchRequirement);
EXPECT_TRUE(drmDirectSubmission.inputMonitorFenceDispatchRequirement);
}
HWTEST_F(DrmDirectSubmissionTest,

74
shared/test/unit_test/direct_submission/windows/wddm_direct_submission_tests.cpp
View File

@ -707,7 +707,7 @@ HWTEST_F(WddmDirectSubmissionTest, givenMiMemFenceRequiredThenGpuVaForAdditional
}
HWTEST_F(WddmDirectSubmissionTest,
givenRenderDirectSubmissionWithDisabledMonitorFenceWhenHasStallingCommandDispatchedThenDispatchPostSyncOperation) {
givenRenderDirectSubmissionWithDisabledMonitorFenceWhenHasStallingCommandDispatchedThenDispatchNoPostSyncOperation) {
using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL;
using POST_SYNC_OPERATION = typename PIPE_CONTROL::POST_SYNC_OPERATION;
using Dispatcher = RenderDispatcher<FamilyType>;
@ -737,8 +737,74 @@ HWTEST_F(WddmDirectSubmissionTest,
FlushStampTracker flushStamp(true);
MockWddmDirectSubmission<FamilyType, Dispatcher> wddmDirectSubmission(*device->getDefaultEngine().commandStreamReceiver);
EXPECT_FALSE(wddmDirectSubmission.inputMonitorFenceDispatchRequirement);
wddmDirectSubmission.disableMonitorFence = false;
EXPECT_TRUE(wddmDirectSubmission.inputMonitorFenceDispatchRequirement);
wddmDirectSubmission.disableMonitorFence = true;
bool ret = wddmDirectSubmission.initialize(true, true);
EXPECT_TRUE(ret);
EXPECT_TRUE(wddmDirectSubmission.useNotifyForPostSync);
size_t sizeUsedBefore = wddmDirectSubmission.ringCommandStream.getUsed();
ret = wddmDirectSubmission.dispatchCommandBuffer(batchBuffer, flushStamp);
EXPECT_TRUE(ret);
HardwareParse hwParse;
hwParse.parsePipeControl = true;
hwParse.parseCommands<FamilyType>(wddmDirectSubmission.ringCommandStream, sizeUsedBefore);
hwParse.findHardwareCommands<FamilyType>();
auto &monitorFence = osContext->getResidencyController().getMonitoredFence();
bool foundFenceUpdate = false;
for (auto it = hwParse.pipeControlList.begin(); it != hwParse.pipeControlList.end(); it++) {
auto pipeControl = genCmdCast<PIPE_CONTROL *>(*it);
if (pipeControl->getPostSyncOperation() == POST_SYNC_OPERATION::POST_SYNC_OPERATION_WRITE_IMMEDIATE_DATA) {
uint64_t pipeControlPostSyncAddress = UnitTestHelper<FamilyType>::getPipeControlPostSyncAddress(*pipeControl);
if (pipeControlPostSyncAddress == monitorFence.gpuAddress) {
foundFenceUpdate = true;
EXPECT_TRUE(pipeControl->getNotifyEnable());
break;
}
}
}
EXPECT_FALSE(foundFenceUpdate);
memoryManager->freeGraphicsMemory(clientCommandBuffer);
}
HWTEST_F(WddmDirectSubmissionTest,
givenRenderDirectSubmissionWithDisabledMonitorFenceWhenMonitorFenceDispatchedThenDispatchPostSyncOperation) {
using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL;
using POST_SYNC_OPERATION = typename PIPE_CONTROL::POST_SYNC_OPERATION;
using Dispatcher = RenderDispatcher<FamilyType>;
BatchBuffer batchBuffer;
GraphicsAllocation *clientCommandBuffer = nullptr;
std::unique_ptr<LinearStream> clientStream;
auto memoryManager = executionEnvironment->memoryManager.get();
const AllocationProperties commandBufferProperties{device->getRootDeviceIndex(), 0x1000,
AllocationType::COMMAND_BUFFER, device->getDeviceBitfield()};
clientCommandBuffer = memoryManager->allocateGraphicsMemoryWithProperties(commandBufferProperties);
ASSERT_NE(nullptr, clientCommandBuffer);
clientStream = std::make_unique<LinearStream>(clientCommandBuffer);
clientStream->getSpace(0x40);
memset(clientStream->getCpuBase(), 0, 0x20);
batchBuffer.endCmdPtr = ptrOffset(clientStream->getCpuBase(), 0x20);
batchBuffer.commandBufferAllocation = clientCommandBuffer;
batchBuffer.usedSize = 0x40;
batchBuffer.taskStartAddress = clientCommandBuffer->getGpuAddress();
batchBuffer.stream = clientStream.get();
batchBuffer.dispatchMonitorFence = true;
FlushStampTracker flushStamp(true);
MockWddmDirectSubmission<FamilyType, Dispatcher> wddmDirectSubmission(*device->getDefaultEngine().commandStreamReceiver);
EXPECT_TRUE(wddmDirectSubmission.inputMonitorFenceDispatchRequirement);
wddmDirectSubmission.disableMonitorFence = true;
bool ret = wddmDirectSubmission.initialize(true, true);
EXPECT_TRUE(ret);
@ -1059,4 +1125,4 @@ HWTEST_F(WddmDirectSubmissionTest, givenDirectSubmissionWhenSwitchingRingBuffers
wddmDirectSubmission.previousRingBuffer = 1;
wddmDirectSubmission.handleSwitchRingBuffers(nullptr);
EXPECT_EQ(wddmDirectSubmission.ringBufferForCompletionFence, wddmDirectSubmission.previousRingBuffer);
}
}