Mirror/jami-client-qt
1
0
Fork 0
mirror of https://github.com/savoirfairelinux/jami-client-qt.git synced 2025-12-18 00:36:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

tests: Avoid takeFirst-caused segfaults on empty arrays.

Browse Source 
Replace EXPECT_EQ with ASSERT_EQ where a failure should be
fatal (abort execution).

Relates-to: <https://git.jami.net/savoirfairelinux/jami-client-qt/-/issues/1507>.
Change-Id: I4b5e38cdc399c1d1a51f72abab23cce963578541
This commit is contained in:
Maxim Cournoyer
2025-07-11 17:04:31 +09:00
committed by Adrien Béraud
parent 76a710e2ab
commit a51078c900
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/unittests/messageparser_unittest.cpp
View File

@@ -49,7 +49,7 @@ TEST_F(MessageParserFixture, TextIsParsedCorrectly)
// Wait for the messageParsed signal which should be emitted once. // Wait for the messageParsed signal which should be emitted once.
messageParsedSpy.wait(); messageParsedSpy.wait();
EXPECT_EQ(messageParsedSpy.count(), 1); ASSERT_EQ(messageParsedSpy.count(), 1);
QList<QVariant> messageParserArguments = messageParsedSpy.takeFirst(); QList<QVariant> messageParserArguments = messageParsedSpy.takeFirst();
EXPECT_TRUE(messageParserArguments.at(0).typeId() == qMetaTypeId<QString>()); EXPECT_TRUE(messageParserArguments.at(0).typeId() == qMetaTypeId<QString>());
@@ -60,7 +60,7 @@ TEST_F(MessageParserFixture, TextIsParsedCorrectly)
// No link info should be returned. // No link info should be returned.
linkInfoReadySpy.wait(); linkInfoReadySpy.wait();
EXPECT_EQ(linkInfoReadySpy.count(), 0); ASSERT_EQ(linkInfoReadySpy.count(), 0);
} }
/*! /*!
@@ -84,7 +84,7 @@ TEST_F(MessageParserFixture, ALinkIsParsedCorrectly)
// Wait for the messageParsed signal which should be emitted once. // Wait for the messageParsed signal which should be emitted once.
messageParsedSpy.wait(); messageParsedSpy.wait();
EXPECT_EQ(messageParsedSpy.count(), 1); ASSERT_EQ(messageParsedSpy.count(), 1);
QList<QVariant> messageParserArguments = messageParsedSpy.takeFirst(); QList<QVariant> messageParserArguments = messageParsedSpy.takeFirst();
EXPECT_TRUE(messageParserArguments.at(0).typeId() == qMetaTypeId<QString>()); EXPECT_TRUE(messageParserArguments.at(0).typeId() == qMetaTypeId<QString>());
@@ -96,7 +96,7 @@ TEST_F(MessageParserFixture, ALinkIsParsedCorrectly)
// Wait for the linkInfoReady signal which should be emitted once. // Wait for the linkInfoReady signal which should be emitted once.
linkInfoReadySpy.wait(); linkInfoReadySpy.wait();
EXPECT_EQ(linkInfoReadySpy.count(), 1); ASSERT_EQ(linkInfoReadySpy.count(), 1);
QList<QVariant> linkInfoReadyArguments = linkInfoReadySpy.takeFirst(); QList<QVariant> linkInfoReadyArguments = linkInfoReadySpy.takeFirst();
EXPECT_TRUE(linkInfoReadyArguments.at(0).typeId() == qMetaTypeId<QString>()); EXPECT_TRUE(linkInfoReadyArguments.at(0).typeId() == qMetaTypeId<QString>());
@@ -180,7 +180,7 @@ TEST_F(MessageParserFixture, EndOfLineCharactersAreParsedCorrectly)
// Wait for the messageParsed signal which should be emitted once. // Wait for the messageParsed signal which should be emitted once.
messageParsedSpy.wait(); messageParsedSpy.wait();
EXPECT_EQ(messageParsedSpy.count(), 1); ASSERT_EQ(messageParsedSpy.count(), 1);
QList<QVariant> messageParserArguments = messageParsedSpy.takeFirst(); QList<QVariant> messageParserArguments = messageParsedSpy.takeFirst();
EXPECT_TRUE(messageParserArguments.at(0).typeId() == qMetaTypeId<QString>()); EXPECT_TRUE(messageParserArguments.at(0).typeId() == qMetaTypeId<QString>());
@@ -210,7 +210,7 @@ TEST_F(MessageParserFixture, FencedCodeIsParsedCorrectly)
// Wait for the messageParsed signal which should be emitted once. // Wait for the messageParsed signal which should be emitted once.
messageParsedSpy.wait(); messageParsedSpy.wait();
EXPECT_EQ(messageParsedSpy.count(), 1); ASSERT_EQ(messageParsedSpy.count(), 1);
QList<QVariant> messageParserArguments = messageParsedSpy.takeFirst(); QList<QVariant> messageParserArguments = messageParsedSpy.takeFirst();
EXPECT_TRUE(messageParserArguments.at(0).typeId() == qMetaTypeId<QString>()); EXPECT_TRUE(messageParserArguments.at(0).typeId() == qMetaTypeId<QString>());
@@ -242,14 +242,14 @@ TEST_F(MessageParserFixture, YoutubeLinkIsParsedCorrectly)
// Wait for the messageParsed signal which should be emitted once. // Wait for the messageParsed signal which should be emitted once.
messageParsedSpy.wait(); messageParsedSpy.wait();
EXPECT_EQ(messageParsedSpy.count(), 1); ASSERT_EQ(messageParsedSpy.count(), 1);
QList<QVariant> messageParserArguments = messageParsedSpy.takeFirst(); QList<QVariant> messageParserArguments = messageParsedSpy.takeFirst();
EXPECT_TRUE(messageParserArguments.at(0).typeId() == qMetaTypeId<QString>()); EXPECT_TRUE(messageParserArguments.at(0).typeId() == qMetaTypeId<QString>());
// Wait for the linkInfoReady signal which should be emitted once. // Wait for the linkInfoReady signal which should be emitted once.
linkInfoReadySpy.wait(); linkInfoReadySpy.wait();
EXPECT_EQ(linkInfoReadySpy.count(), 1); ASSERT_EQ(linkInfoReadySpy.count(), 1);
QList<QVariant> linkInfoReadyArguments = linkInfoReadySpy.takeFirst(); QList<QVariant> linkInfoReadyArguments = linkInfoReadySpy.takeFirst();
EXPECT_TRUE(linkInfoReadyArguments.at(0).typeId() == qMetaTypeId<QString>()); EXPECT_TRUE(linkInfoReadyArguments.at(0).typeId() == qMetaTypeId<QString>());