Virtualization
/
SLOF
mirror of https://gitlab.com/qemu-project/SLOF.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

virtio: Compile with -Wextra 

-Wextra enables a bunch of rather useful checks which this fixes.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
This commit is contained in:
Alexey Kardashevskiy 2021-01-27 19:37:02 +11:00
parent 7ef3ec384d
commit c79e3375e6
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/libvirtio/p9.c
View File

@ -142,7 +142,7 @@ void reset_buffers(void)
int p9_transaction(p9_connection_t *connection)
{
int rc;
int tx_size = GET_SIZE;
uint32_t tx_size = GET_SIZE;
uint32_t rx_size = connection->message_size;
if (transact == NULL) {
@ -248,7 +248,7 @@ int p9_version(p9_connection_t *connection)
int p9_attach(p9_connection_t *connection)
{
int rc;
int length = 19 + strlen(connection->uname) + strlen(connection->aname);
unsigned length = 19 + strlen(connection->uname) + strlen(connection->aname);
if (length > connection->message_size) {
return P9_MSG_TOO_LONG;
@ -372,8 +372,8 @@ int p9_walk(p9_connection_t *connection, uint32_t fid, uint32_t new_fid,
s_tok = e_tok;
continue;
}
int tx_size = (e_tok - s_tok + 2 + GET_SIZE);
int rx_size = ((element_count + 1) * MSG_QID_SIZE
unsigned tx_size = (e_tok - s_tok + 2 + GET_SIZE);
unsigned rx_size = ((element_count + 1) * MSG_QID_SIZE
+ MSG_WALK_RX_HDR_SIZE);
if ((tx_size > connection->message_size)
|| (rx_size > connection->message_size)) {

2
lib/libvirtio/virtio.c
View File

@ -436,7 +436,7 @@ struct vqs *virtio_queue_init_vq(struct virtio_device *dev, unsigned int id)
void virtio_queue_term_vq(struct virtio_device *dev, struct vqs *vq, unsigned int id)
{
if (vq->desc_gpas) {
int i;
unsigned i;
for (i = 0; i < vq->size; ++i)
virtio_free_desc(vq, i, dev->features);