From 270d16e4582f9a51a28a8d262fee6d3612d8abfa Mon Sep 17 00:00:00 2001 From: Rot127 <45763064+Rot127@users.noreply.github.com> Date: Tue, 18 Jul 2023 15:57:31 +0000 Subject: [PATCH] Fix VFP feature check. (#2090) VFP instructions could only be disassembled if armv8 was set as arch. This is because the predicate fails due to this feature check. This is incorrect as also armv7 can have VFP support. --- arch/ARM/ARMDisassembler.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/ARM/ARMDisassembler.c b/arch/ARM/ARMDisassembler.c index b2e5723a..03b9fc13 100644 --- a/arch/ARM/ARMDisassembler.c +++ b/arch/ARM/ARMDisassembler.c @@ -392,10 +392,9 @@ bool ARM_getFeatureBits(unsigned int mode, unsigned int feature) feature == ARM_HasV8_4aOps || feature == ARM_HasV8_3aOps) // HasV8MBaselineOps return false; - } else { - if (feature == ARM_FeatureVFPOnlySP) - return false; } + if (feature == ARM_FeatureVFPOnlySP) + return false; if ((mode & CS_MODE_MCLASS) == 0) { if (feature == ARM_FeatureMClass)