Virtualization
/
dtc
mirror of https://gitlab.com/qemu-project/dtc.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Prevent crash on modulo by zero 

1937095 "Prevent crash on division by zero" fixed a crash when attempting
a division by zero using the / operator in a dts.  However, it missed the
precisely equivalent crash with the % (modulus) operator.  This patch fixes
the oversight.

Reported-by: Anton Blanchard <anton@samba.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
David Gibson 2016-01-12 19:27:25 +11:00
parent b43345039b
commit b06e55c88b
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dtc-parser.y
View File

@ -419,7 +419,15 @@ integer_mul:
$$ = 0;
}
}
| integer_mul '%' integer_unary { $$ = $1 % $3; }
| integer_mul '%' integer_unary
{
if ($3 != 0) {
$$ = $1 % $3;
} else {
ERROR(&@$, "Division by zero");
$$ = 0;
}
}
| integer_unary
;

3
tests/division-by-zero.dts
View File

@ -1,5 +1,6 @@
/dts-v1/;
/ {
prop = < (1/0) >;
prop-div = < (1/0) >;
prop-mod = < (1%0) >;
};