Virtualization
/
edk2
mirror of https://gitlab.com/qemu-project/edk2.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

MdeModulePkg/UefiBootManagerLib: BmGetActiveConsoleIn code cleanup 

Check for NULL from AllocateCopyPool before setting Count to 1. Also
change sizeof (EFI_HANDLE*) to sizeof (EFI_HANDLE).  Handles is a
EFI_HANDLE pointer, so the allocated memory must be the size of
EFI_HANDLE.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
This commit is contained in:
Thomas Palmer 2016-03-31 01:16:48 +08:00 committed by Ruiyu Ni
parent 7361d3ff88
commit 065e587c17
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
MdeModulePkg/Library/UefiBootManagerLib/BmHotkey.c
View File

@ -2,6 +2,7 @@
Hotkey library functions. Hotkey library functions.
Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR> Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -471,8 +472,10 @@ BmGetActiveConsoleIn (
EFI_OPEN_PROTOCOL_TEST_PROTOCOL EFI_OPEN_PROTOCOL_TEST_PROTOCOL
); );
if (!EFI_ERROR (Status)) { if (!EFI_ERROR (Status)) {
Handles = AllocateCopyPool (sizeof (EFI_HANDLE *), &gST->ConsoleInHandle); Handles = AllocateCopyPool (sizeof (EFI_HANDLE), &gST->ConsoleInHandle);
*Count = 1; if (Handles != NULL) {
*Count = 1;
}
} }
} else { } else {
Status = gBS->LocateHandleBuffer ( Status = gBS->LocateHandleBuffer (