Virtualization
/
edk2
mirror of https://gitlab.com/qemu-project/edk2.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE 

This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
This commit is contained in:
Pierre Gondois 2021-01-15 17:35:22 +00:00 committed by mergify[bot]
parent 063f8483b9
commit 96479947bc
3 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h
View File

@ -1,6 +1,6 @@
/** @file /** @file
Copyright (c) 2017-2018, Arm Limited. All rights reserved. Copyright (c) 2017-2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent SPDX-License-Identifier: BSD-2-Clause-Patent
@ -22,7 +22,7 @@
#define NUM_REMAIN_PERF_LEVELS_SHIFT 16 #define NUM_REMAIN_PERF_LEVELS_SHIFT 16
#define NUM_REMAIN_PERF_LEVELS(Lvls) (Lvls >> NUM_REMAIN_PERF_LEVELS_SHIFT) #define NUM_REMAIN_PERF_LEVELS(Lvls) (Lvls >> NUM_REMAIN_PERF_LEVELS_SHIFT)
/** Return values for SCMI_MESSAGE_ID_PERFORMANCE_DESCRIBE_LEVELS command. /** Return values for ScmiMessageIdPerformanceDescribeLevels command.
SCMI Spec section 4.5.2.5 SCMI Spec section 4.5.2.5
**/ **/
typedef struct { typedef struct {

12
ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c
View File

@ -108,7 +108,7 @@ PerformanceDomainAttributes (
*MessageParams = DomainId; *MessageParams = DomainId;
Cmd.ProtocolId = ScmiProtocolIdPerformance; Cmd.ProtocolId = ScmiProtocolIdPerformance;
Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_DOMAIN_ATTRIBUTES; Cmd.MessageId = ScmiMessageIdPerformanceDomainAttributes;
PayloadLength = sizeof (DomainId); PayloadLength = sizeof (DomainId);
@ -180,7 +180,7 @@ PerformanceDescribeLevels (
*MessageParams++ = DomainId; *MessageParams++ = DomainId;
Cmd.ProtocolId = ScmiProtocolIdPerformance; Cmd.ProtocolId = ScmiProtocolIdPerformance;
Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_DESCRIBE_LEVELS; Cmd.MessageId = ScmiMessageIdPerformanceDescribeLevels;
do { do {
@ -259,7 +259,7 @@ PerformanceLimitsSet (
*MessageParams = Limits->RangeMin; *MessageParams = Limits->RangeMin;
Cmd.ProtocolId = ScmiProtocolIdPerformance; Cmd.ProtocolId = ScmiProtocolIdPerformance;
Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_LIMITS_SET; Cmd.MessageId = ScmiMessageIdPerformanceLimitsSet;
PayloadLength = sizeof (DomainId) + sizeof (SCMI_PERFORMANCE_LIMITS); PayloadLength = sizeof (DomainId) + sizeof (SCMI_PERFORMANCE_LIMITS);
@ -305,7 +305,7 @@ PerformanceLimitsGet (
*MessageParams = DomainId; *MessageParams = DomainId;
Cmd.ProtocolId = ScmiProtocolIdPerformance; Cmd.ProtocolId = ScmiProtocolIdPerformance;
Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_LIMITS_GET; Cmd.MessageId = ScmiMessageIdPerformanceLimitsGet;
PayloadLength = sizeof (DomainId); PayloadLength = sizeof (DomainId);
@ -355,7 +355,7 @@ PerformanceLevelSet (
*MessageParams = Level; *MessageParams = Level;
Cmd.ProtocolId = ScmiProtocolIdPerformance; Cmd.ProtocolId = ScmiProtocolIdPerformance;
Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_LEVEL_SET; Cmd.MessageId = ScmiMessageIdPerformanceLevelSet;
PayloadLength = sizeof (DomainId) + sizeof (Level); PayloadLength = sizeof (DomainId) + sizeof (Level);
@ -400,7 +400,7 @@ PerformanceLevelGet (
*MessageParams = DomainId; *MessageParams = DomainId;
Cmd.ProtocolId = ScmiProtocolIdPerformance; Cmd.ProtocolId = ScmiProtocolIdPerformance;
Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_LEVEL_GET; Cmd.MessageId = ScmiMessageIdPerformanceLevelGet;
PayloadLength = sizeof (DomainId); PayloadLength = sizeof (DomainId);

14
ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h
View File

@ -1,6 +1,6 @@
/** @file /** @file
Copyright (c) 2017-2018, Arm Limited. All rights reserved. Copyright (c) 2017-2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent SPDX-License-Identifier: BSD-2-Clause-Patent
@ -247,12 +247,12 @@ typedef struct _SCMI_PERFORMANCE_PROTOCOL {
} SCMI_PERFORMANCE_PROTOCOL; } SCMI_PERFORMANCE_PROTOCOL;
typedef enum { typedef enum {
SCMI_MESSAGE_ID_PERFORMANCE_DOMAIN_ATTRIBUTES = 0x3, ScmiMessageIdPerformanceDomainAttributes = 0x3,
SCMI_MESSAGE_ID_PERFORMANCE_DESCRIBE_LEVELS = 0x4, ScmiMessageIdPerformanceDescribeLevels = 0x4,
SCMI_MESSAGE_ID_PERFORMANCE_LIMITS_SET = 0x5, ScmiMessageIdPerformanceLimitsSet = 0x5,
SCMI_MESSAGE_ID_PERFORMANCE_LIMITS_GET = 0x6, ScmiMessageIdPerformanceLimitsGet = 0x6,
SCMI_MESSAGE_ID_PERFORMANCE_LEVEL_SET = 0x7, ScmiMessageIdPerformanceLevelSet = 0x7,
SCMI_MESSAGE_ID_PERFORMANCE_LEVEL_GET = 0x8, ScmiMessageIdPerformanceLevelGet = 0x8,
} SCMI_MESSAGE_ID_PERFORMANCE; } SCMI_MESSAGE_ID_PERFORMANCE;
#endif /* ARM_SCMI_PERFORMANCE_PROTOCOL_H_ */ #endif /* ARM_SCMI_PERFORMANCE_PROTOCOL_H_ */