Virtualization
/
edk2
mirror of https://gitlab.com/qemu-project/edk2.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

MdeModulePkg/NonDiscoverableDeviceRegistrationLib: Fix coding style issues 

1. Fix issues in comments
2. Fix Guid/protocol format

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
This commit is contained in:
Dandan Bi 2016-12-19 15:02:24 +08:00 committed by Hao Wu
parent a9e0c1f6ac
commit 9a882490e4
3 changed files with 27 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
MdeModulePkg/Include/Library/NonDiscoverableDeviceRegistrationLib.h
View File

@ -32,7 +32,7 @@ typedef enum {
/** /**
Register a non-discoverable MMIO device Register a non-discoverable MMIO device
@param[in] DeviceType The type of non-discoverable device @param[in] Type The type of non-discoverable device
@param[in] DmaType Whether the device is DMA coherent @param[in] DmaType Whether the device is DMA coherent
@param[in] InitFunc Initialization routine to be invoked when @param[in] InitFunc Initialization routine to be invoked when
the device is enabled the device is enabled
@ -43,6 +43,8 @@ typedef enum {
@param[in] NumMmioResources The number of UINTN base/size pairs that @param[in] NumMmioResources The number of UINTN base/size pairs that
follow, each describing an MMIO region follow, each describing an MMIO region
owned by the device owned by the device
@param[in] ... The variable argument list which contains the
info about MmioResources.
@retval EFI_SUCCESS The registration succeeded. @retval EFI_SUCCESS The registration succeeded.
@retval Other The registration failed. @retval Other The registration failed.

14
MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.c
View File

@ -25,6 +25,14 @@
#include <Protocol/DevicePath.h> #include <Protocol/DevicePath.h>
#include <Protocol/NonDiscoverableDevice.h> #include <Protocol/NonDiscoverableDevice.h>
/**
Get Guid form the type of non-discoverable device.
@param[in] Type The type of non-discoverable device.
@retval Return the Guid.
**/
STATIC STATIC
CONST EFI_GUID * CONST EFI_GUID *
GetGuidFromType ( GetGuidFromType (
@ -74,9 +82,9 @@ typedef struct {
#pragma pack () #pragma pack ()
/** /**
Register a non-discoverable MMIO device Register a non-discoverable MMIO device.
@param[in] DeviceType The type of non-discoverable device @param[in] Type The type of non-discoverable device
@param[in] DmaType Whether the device is DMA coherent @param[in] DmaType Whether the device is DMA coherent
@param[in] InitFunc Initialization routine to be invoked when @param[in] InitFunc Initialization routine to be invoked when
the device is enabled the device is enabled
@ -87,6 +95,8 @@ typedef struct {
@param[in] NumMmioResources The number of UINTN base/size pairs that @param[in] NumMmioResources The number of UINTN base/size pairs that
follow, each describing an MMIO region follow, each describing an MMIO region
owned by the device owned by the device
@param[in] ... The variable argument list which contains the
info about MmioResources.
@retval EFI_SUCCESS The registration succeeded. @retval EFI_SUCCESS The registration succeeded.
@retval EFI_INVALID_PARAMETER An invalid argument was given @retval EFI_INVALID_PARAMETER An invalid argument was given

22
MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
View File

@ -1,4 +1,6 @@
# @file # @file
# Component Description File for NonDiscoverableDeviceRegistrationLib.
#
# Copyright (c) 2016, Linaro, Ltd. All rights reserved.<BR> # Copyright (c) 2016, Linaro, Ltd. All rights reserved.<BR>
# #
# This program and the accompanying materials # This program and the accompanying materials
@ -32,15 +34,15 @@
UefiBootServicesTableLib UefiBootServicesTableLib
[Protocols] [Protocols]
gEdkiiNonDiscoverableDeviceProtocolGuid gEdkiiNonDiscoverableDeviceProtocolGuid ## PRODUCES
[Guids] [Guids]
gEdkiiNonDiscoverableAhciDeviceGuid gEdkiiNonDiscoverableAhciDeviceGuid ## CONSUMES ## GUID
gEdkiiNonDiscoverableAmbaDeviceGuid gEdkiiNonDiscoverableAmbaDeviceGuid ## CONSUMES ## GUID
gEdkiiNonDiscoverableEhciDeviceGuid gEdkiiNonDiscoverableEhciDeviceGuid ## CONSUMES ## GUID
gEdkiiNonDiscoverableNvmeDeviceGuid gEdkiiNonDiscoverableNvmeDeviceGuid ## CONSUMES ## GUID
gEdkiiNonDiscoverableOhciDeviceGuid gEdkiiNonDiscoverableOhciDeviceGuid ## CONSUMES ## GUID
gEdkiiNonDiscoverableSdhciDeviceGuid gEdkiiNonDiscoverableSdhciDeviceGuid ## CONSUMES ## GUID
gEdkiiNonDiscoverableUfsDeviceGuid gEdkiiNonDiscoverableUfsDeviceGuid ## CONSUMES ## GUID
gEdkiiNonDiscoverableUhciDeviceGuid gEdkiiNonDiscoverableUhciDeviceGuid ## CONSUMES ## GUID
gEdkiiNonDiscoverableXhciDeviceGuid gEdkiiNonDiscoverableXhciDeviceGuid ## CONSUMES ## GUID