mirror of
https://gitlab.com/qemu-project/edk2.git
synced 2025-10-30 07:56:39 +08:00
BaseTools/PatchCheck.py: verify commit message lists package(s)
Verify that the subject line matches the basic
{Package}[,Package]:
format _or_ the
Revert "<subject of commit to revert>"
format.
Non-package top-level directories are treated as packages.
Suggested-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Leif Lindholm <leif.lindholm@oss.qualcomm.com>
This commit is contained in:
committed by
mergify[bot]
parent
c44efa0fbd
commit
b55530ad44
@ -117,6 +117,7 @@ class CommitMessageCheck:
|
||||
|
||||
self.check_contributed_under()
|
||||
if not MergifyMerge:
|
||||
self.check_subject(updated_packages)
|
||||
self.check_signed_off_by()
|
||||
self.check_misc_signatures()
|
||||
self.check_overall_format()
|
||||
@ -209,6 +210,14 @@ class CommitMessageCheck:
|
||||
|
||||
return sigs
|
||||
|
||||
def check_subject(self, updated_packages):
|
||||
if updated_packages:
|
||||
for package in updated_packages:
|
||||
current_package_re = r"(Revert \"|^|, ?)" + re.escape(package) + r"([ ,:\/])"
|
||||
if not re.search(current_package_re, self.subject):
|
||||
self.error("Subject line not in \"package/component: description\" format!")
|
||||
return
|
||||
|
||||
def check_signed_off_by(self):
|
||||
sob='Signed-off-by'
|
||||
if self.msg.find(sob) < 0:
|
||||
|
||||
Reference in New Issue
Block a user