ShellPkg: UefiShellCommandLib: CodeQL Fixes

Includes changes across the module for the following CodeQL rules:
 - cpp/comparison-with-wider-type
 - cpp/overflow-buffer
 - cpp/redundant-null-check-param
 - cpp/uselesstest

Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com>

Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>

ShellPkg/Library/UefiShellCommandLib/ConsistMapping.c

@@ -1404,6 +1404,10 @@ GetHIDevicePath (
   NonHIDevicePathNodeCount = 0;
 
   HIDevicePath = AllocateZeroPool (sizeof (EFI_DEVICE_PATH_PROTOCOL));
+  if (HIDevicePath == NULL) {
+    return NULL;
+  }
+
   SetDevicePathEndNode (HIDevicePath);
 
   Node.DevPath.Type      = END_DEVICE_PATH_TYPE;

ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c

@@ -1142,7 +1142,7 @@ DeleteScriptFileStruct (
   IN SCRIPT_FILE  *Script
   )
 {
-  UINT8  LoopVar;
+  UINTN  LoopVar;
 
   if (Script == NULL) {
     return;
@@ -1263,6 +1263,10 @@ ShellCommandCreateNewMappingName (
   String = NULL;
 
   String = AllocateZeroPool (PcdGet8 (PcdShellMapNameLength) * sizeof (String[0]));
+  if (String == NULL) {
+    return (NULL);
+  }
+
   UnicodeSPrint (
     String,
     PcdGet8 (PcdShellMapNameLength) * sizeof (String[0]),
@@ -1459,7 +1463,13 @@ ShellCommandCreateInitialMappingsAndPaths (
     //
     PerformQuickSort (DevicePathList, Count, sizeof (EFI_DEVICE_PATH_PROTOCOL *), DevicePathCompare);
 
-    if (!EFI_ERROR (ShellCommandConsistMappingInitialize (&ConsistMappingTable))) {
+    Status = ShellCommandConsistMappingInitialize (&ConsistMappingTable);
+    if (EFI_ERROR (Status)) {
+      SHELL_FREE_NON_NULL (HandleList);
+      SHELL_FREE_NON_NULL (DevicePathList);
+      return Status;
+    }
+
     //
     // Assign new Mappings to all...
     //
@@ -1468,7 +1478,12 @@ ShellCommandCreateInitialMappingsAndPaths (
       // Get default name first
       //
       NewDefaultName = ShellCommandCreateNewMappingName (MappingTypeFileSystem);
+      if (NewDefaultName == NULL) {
         ASSERT (NewDefaultName != NULL);
+        Status = EFI_OUT_OF_RESOURCES;
+        break;
+      }
+
       Status = ShellCommandAddMapItemAndUpdatePath (NewDefaultName, DevicePathList[Count], 0, TRUE);
       ASSERT_EFI_ERROR (Status);
       FreePool (NewDefaultName);
@@ -1483,7 +1498,6 @@ ShellCommandCreateInitialMappingsAndPaths (
         FreePool (NewConsistName);
       }
     }
-    }
 
     if (ConsistMappingTable != NULL) {
       ShellCommandConsistMappingUnInitialize (ConsistMappingTable);
@@ -1561,7 +1575,13 @@ ShellCommandCreateInitialMappingsAndPaths (
       // Get default name first
       //
       NewDefaultName = ShellCommandCreateNewMappingName (MappingTypeBlockIo);
+      if (NewDefaultName == NULL) {
         ASSERT (NewDefaultName != NULL);
+        SHELL_FREE_NON_NULL (HandleList);
+        SHELL_FREE_NON_NULL (DevicePathList);
+        return EFI_OUT_OF_RESOURCES;
+      }
+
       Status = ShellCommandAddMapItemAndUpdatePath (NewDefaultName, DevicePathList[Count], 0, FALSE);
       ASSERT_EFI_ERROR (Status);
       FreePool (NewDefaultName);
@@ -1631,6 +1651,11 @@ ShellCommandUpdateMapping (
     PerformQuickSort (DevicePathList, Count, sizeof (EFI_DEVICE_PATH_PROTOCOL *), DevicePathCompare);
 
     Status = ShellCommandConsistMappingInitialize (&ConsistMappingTable);
+    if (EFI_ERROR (Status)) {
+      SHELL_FREE_NON_NULL (HandleList);
+      SHELL_FREE_NON_NULL (DevicePathList);
+      return Status;
+    }
 
     //
     // Assign new Mappings to remainders

ShellPkg/Library/UefiShellLevel1CommandsLib/For.c

@@ -691,6 +691,8 @@ ShellCommandRunFor (
 
       TempString = AllocateZeroPool (50*sizeof (CHAR16));
       if (TempString == NULL) {
+        SHELL_FREE_NON_NULL (ArgSet);
+        SHELL_FREE_NON_NULL (Info);
         return (SHELL_OUT_OF_RESOURCES);
       }