From ddacfa238aa99399256897df2e193a5a730dee29 Mon Sep 17 00:00:00 2001
From: Dongyan Qian <qiandongyan@loongson.cn>
Date: Wed, 11 Jun 2025 11:57:22 +0800
Subject: [PATCH] PrmPkg/DxePrmContextBufferLib: Free handle buffers after
 LocateHandleBuffer

Fix memory leaks by adding missing FreePool calls:
cleanup HandleBuffer in GetModuleContextBuffers.

REF: https://uefi.org/sites/default/files/resources/UEFI_Spec_Final_2.11.pdf
Chapter 7.3.15: "Services - Boot Services.LocateHandleBuffer":
It is the caller's responsibility to call the Boot Service.FreePool when
the caller no longer requires the contents of Buffer.

Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
---
 .../DxePrmContextBufferLib.c                  | 71 +++++++++++--------
 1 file changed, 40 insertions(+), 31 deletions(-)

diff --git a/PrmPkg/Library/DxePrmContextBufferLib/DxePrmContextBufferLib.c b/PrmPkg/Library/DxePrmContextBufferLib/DxePrmContextBufferLib.c
index a6ad141556..b265c19340 100644
--- a/PrmPkg/Library/DxePrmContextBufferLib/DxePrmContextBufferLib.c
+++ b/PrmPkg/Library/DxePrmContextBufferLib/DxePrmContextBufferLib.c
@@ -104,37 +104,41 @@ GetModuleContextBuffers (
                   &HandleCount,
                   &HandleBuffer
                   );
-  if (!EFI_ERROR (Status)) {
-    for (Index = 0; Index < HandleCount; Index++) {
-      Status = gBS->HandleProtocol (
-                      HandleBuffer[Index],
-                      &gPrmConfigProtocolGuid,
-                      (VOID **)&PrmConfigProtocol
-                      );
-      ASSERT_EFI_ERROR (Status);
-      if (EFI_ERROR (Status) || (PrmConfigProtocol == NULL)) {
-        continue;
+  if (EFI_ERROR (Status)) {
+    return Status;
+  }
+
+  for (Index = 0; Index < HandleCount; Index++) {
+    Status = gBS->HandleProtocol (
+                    HandleBuffer[Index],
+                    &gPrmConfigProtocolGuid,
+                    (VOID **)&PrmConfigProtocol
+                    );
+    ASSERT_EFI_ERROR (Status);
+    if (EFI_ERROR (Status) || (PrmConfigProtocol == NULL)) {
+      continue;
+    }
+
+    if (GuidSearchType == ByModuleGuid) {
+      if (CompareGuid (&PrmConfigProtocol->ModuleContextBuffers.ModuleGuid, Guid)) {
+        DEBUG ((
+          DEBUG_INFO,
+          "      %a %a: Found a PRM configuration protocol for PRM module %g.\n",
+          _DBGMSGID_,
+          __func__,
+          Guid
+          ));
+
+        *PrmModuleContextBuffers = &PrmConfigProtocol->ModuleContextBuffers;
+        Status                   = EFI_SUCCESS;
+        goto Exit;
       }
-
-      if (GuidSearchType == ByModuleGuid) {
-        if (CompareGuid (&PrmConfigProtocol->ModuleContextBuffers.ModuleGuid, Guid)) {
-          DEBUG ((
-            DEBUG_INFO,
-            "      %a %a: Found a PRM configuration protocol for PRM module %g.\n",
-            _DBGMSGID_,
-            __func__,
-            Guid
-            ));
-
-          *PrmModuleContextBuffers = &PrmConfigProtocol->ModuleContextBuffers;
-          return EFI_SUCCESS;
-        }
-      } else {
-        Status = FindContextBufferInModuleBuffers (Guid, &PrmConfigProtocol->ModuleContextBuffers, &PrmContextBuffer);
-        if (!EFI_ERROR (Status)) {
-          *PrmModuleContextBuffers = &PrmConfigProtocol->ModuleContextBuffers;
-          return EFI_SUCCESS;
-        }
+    } else {
+      Status = FindContextBufferInModuleBuffers (Guid, &PrmConfigProtocol->ModuleContextBuffers, &PrmContextBuffer);
+      if (!EFI_ERROR (Status)) {
+        *PrmModuleContextBuffers = &PrmConfigProtocol->ModuleContextBuffers;
+        Status                   = EFI_SUCCESS;
+        goto Exit;
       }
     }
   }
@@ -147,7 +151,12 @@ GetModuleContextBuffers (
     Guid
     ));
 
-  return EFI_NOT_FOUND;
+  Status = EFI_NOT_FOUND;
+
+Exit:
+  gBS->FreePool (HandleBuffer);
+
+  return Status;
 }
 
 /**