From e172ea16a7002f736a0c3d39c127a890f120d374 Mon Sep 17 00:00:00 2001 From: erictian Date: Fri, 5 Mar 2010 04:35:26 +0000 Subject: [PATCH] roll back the parameter check of AsyncInterruptTransfer() and SyncInterruptTransfer() of Usb2HcProtocol to follow current uefi spec. current uefi spec only supports interrupt in endpoint. but there are usb devices which support interrupt out endpoint. we propose to update uefi spec to remove the limitation. after the ecr is approved, the corresponding patch will be submitted. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10205 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c b/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c index 6cf4aefea6..3161ede949 100644 --- a/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c +++ b/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c @@ -969,8 +969,7 @@ EhcAsyncInterruptTransfer ( // // Validate parameters // - if (!(EndPointAddress >= 0x01 && EndPointAddress <= 0x0F) - && !(EndPointAddress >= 0x81 && EndPointAddress <= 0x8F)) { + if (!EHCI_IS_DATAIN (EndPointAddress)) { return EFI_INVALID_PARAMETER; } @@ -1119,8 +1118,7 @@ EhcSyncInterruptTransfer ( return EFI_INVALID_PARAMETER; } - if (!(EndPointAddress >= 0x01 && EndPointAddress <= 0x0F) - && !(EndPointAddress >= 0x81 && EndPointAddress <= 0x8F)) { + if (!EHCI_IS_DATAIN (EndPointAddress)) { return EFI_INVALID_PARAMETER; }