edk2/SecurityPkg/Library/DxeImageVerificationLib
Laszlo Ersek 0b143fa43e SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)
The DxeImageVerificationHandler() function currently checks whether
"SecDataDir" has enough room for "WinCertificate->dwLength". However, for
advancing "OffSet", "WinCertificate->dwLength" is aligned to the next
multiple of 8. If "WinCertificate->dwLength" is large enough, the
alignment will return 0, and "OffSet" will be stuck at the same value.

Check whether "SecDataDir" has room left for both
"WinCertificate->dwLength" and the alignment.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Wenyi Xie <xiewenyi2@huawei.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2215
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20200901091221.20948-4-lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Wenyi Xie <xiewenyi2@huawei.com>
Reviewed-by: Min M Xu <min.m.xu@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
2020-09-02 10:16:18 +00:00
..
DxeImageVerificationLib.c SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562) 2020-09-02 10:16:18 +00:00
DxeImageVerificationLib.h SecurityPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:23 -07:00
DxeImageVerificationLib.inf SecurityPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:23 -07:00
DxeImageVerificationLib.uni SecurityPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:23 -07:00
Measurement.c SecurityPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:23 -07:00