From 019fda91d0cb4308803c32e8d9dd311b85caf702 Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Thu, 16 Feb 2023 12:03:06 -0800 Subject: [PATCH] vala: don't build .h, .vala, and .gir if export_dynamic is False The current check results in *any* value to `export_dynamic` generating vala import targets, even `false`. This is pretty clearly wrong, as it really wants to treat an unset export_dynamic as false. --- mesonbuild/build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mesonbuild/build.py b/mesonbuild/build.py index d954e430d..62278cea3 100644 --- a/mesonbuild/build.py +++ b/mesonbuild/build.py @@ -1075,7 +1075,7 @@ class BuildTarget(Target): self.add_pch('c', extract_as_list(kwargs, 'c_pch')) self.add_pch('cpp', extract_as_list(kwargs, 'cpp_pch')) - if not isinstance(self, Executable) or 'export_dynamic' in kwargs: + if not isinstance(self, Executable) or kwargs.get('export_dynamic', False): self.vala_header = kwargs.get('vala_header', self.name + '.h') self.vala_vapi = kwargs.get('vala_vapi', self.name + '.vapi') self.vala_gir = kwargs.get('vala_gir', None)