Virtualization
/
meson
mirror of https://gitlab.com/qemu-project/meson.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

As per jpakkane's suggestion use `Popen_safe` instead of `subprocess.getoutput` 

Jussi suggested to use `Popen_safe` from meson's library for portability reasons.
This commit is contained in:
Leif Middelschulte 2017-09-30 19:45:24 +02:00
parent 50376cca37
commit 078527a744
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mesonbuild/wrap/wrap.py
View File

@ -237,7 +237,8 @@ class Resolver:
revno = p.get('revision') revno = p.get('revision')
is_there = os.path.isdir(checkoutdir) is_there = os.path.isdir(checkoutdir)
if is_there: if is_there:
current_revno = subprocess.getoutput(' '.join(['svn', 'info', '--show-item', 'revision', checkoutdir])) p, out = Popen_safe(['svn', 'info', '--show-item', 'revision', checkoutdir])
current_revno = out
if current_revno == revno: if current_revno == revno:
return return