Added .so to list possible darwin dynamic library suffixes (#4364)
Occasionally Darwin libraries can be .so rather than .dylib e.g. tensorflow_cc.so tensorflow_cc is a c++ API for Tensorflow (https://github.com/FloopCZ/tensorflow_cc) which was primarily written for Linux but is also compilable on Darwin. Possibly through laziness, possibly just to have consistent filenames, the developers did not opt to change the suffix from the Linux default when this is compiled on Darwin. Also, the Darwin linker will find libraries with a .so suffix if they are in its path. find_library() needs to match the linker behaviour.
This commit is contained in:
parent
b9e405c634
commit
0ea626b89d
|
@ -896,7 +896,7 @@ class CCompiler(Compiler):
|
|||
prefixes = ['lib', '']
|
||||
# Library suffixes and prefixes
|
||||
if for_darwin(env.is_cross_build(), env):
|
||||
shlibext = ['dylib']
|
||||
shlibext = ['dylib', 'so']
|
||||
elif for_windows(env.is_cross_build(), env):
|
||||
# FIXME: .lib files can be import or static so we should read the
|
||||
# file, figure out which one it is, and reject the wrong kind.
|
||||
|
|
|
@ -584,7 +584,7 @@ class InternalTests(unittest.TestCase):
|
|||
'static': unix_static},
|
||||
'linux': {'shared': ('lib{}.so', '{}.so'),
|
||||
'static': unix_static},
|
||||
'darwin': {'shared': ('lib{}.dylib', '{}.dylib'),
|
||||
'darwin': {'shared': ('lib{}.dylib', 'lib{}.so', '{}.dylib', '{}.so'),
|
||||
'static': unix_static},
|
||||
'cygwin': {'shared': ('cyg{}.dll', 'cyg{}.dll.a', 'lib{}.dll',
|
||||
'lib{}.dll.a', '{}.dll', '{}.dll.a'),
|
||||
|
|
Loading…
Reference in New Issue