Virtualization
/
meson
mirror of https://gitlab.com/qemu-project/meson.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

unit tests: Don't keep builddirs inside source tree on Cygwin 

Seems to cause the umask tests to fail:
https://github.com/mesonbuild/meson/pull/5546#issuecomment-509666523
This commit is contained in:
Nirbheek Chauhan 2019-07-12 13:10:30 +05:30 committed by Jussi Pakkanen
parent d5cb1c2f19
commit 264533cb67
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
run_unittests.py
View File

@ -1199,9 +1199,17 @@ class BasePlatformTests(unittest.TestCase):
self.builddirs.append(self.builddir) self.builddirs.append(self.builddir)
def new_builddir(self): def new_builddir(self):
if not is_cygwin():
# Keep builddirs inside the source tree so that virus scanners
# don't complain
newdir = tempfile.mkdtemp(dir=os.getcwd())
else:
# But not on Cygwin because that breaks the umask tests. See:
# https://github.com/mesonbuild/meson/pull/5546#issuecomment-509666523
newdir = tempfile.mkdtemp()
# In case the directory is inside a symlinked directory, find the real # In case the directory is inside a symlinked directory, find the real
# path otherwise we might not find the srcdir from inside the builddir. # path otherwise we might not find the srcdir from inside the builddir.
newdir = os.path.realpath(tempfile.mkdtemp(dir=os.getcwd())) newdir = os.path.realpath(newdir)
self.change_builddir(newdir) self.change_builddir(newdir)
def _print_meson_log(self): def _print_meson_log(self):