Virtualization
/
meson
mirror of https://gitlab.com/qemu-project/meson.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

cuda module: fix type signature for oneshot function 

It is only ever invoked once. It has a statically known signature based
on how it's used, so there's no good reason to allow it to accept any
defaults -- and defaulting to None messes with type safety.

Saturate is always given, so don't claim it is only sometimes.
This commit is contained in:
Eli Schwartz 2024-01-03 23:06:23 -05:00
parent cf35d9b4ce
commit 8ff25c0bca
No known key found for this signature in database
GPG Key ID: CEB167EFB5722BD6
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mesonbuild/modules/cuda.py
View File

@ -157,11 +157,11 @@ class CudaModule(NewExtensionModule):
return cuda_version, arch_list, detected return cuda_version, arch_list, detected
def _filter_cuda_arch_list(self, cuda_arch_list, lo=None, hi=None, saturate=None): def _filter_cuda_arch_list(self, cuda_arch_list, lo: str, hi: T.Optional[str], saturate: str) -> T.List[str]:
""" """
Filter CUDA arch list (no codenames) for >= low and < hi architecture Filter CUDA arch list (no codenames) for >= low and < hi architecture
bounds, and deduplicate. bounds, and deduplicate.
If saturate is provided, architectures >= hi are replaced with saturate. Architectures >= hi are replaced with saturate.
""" """
filtered_cuda_arch_list = [] filtered_cuda_arch_list = []
@ -170,8 +170,6 @@ class CudaModule(NewExtensionModule):
if lo and version_compare(arch, '<' + lo): if lo and version_compare(arch, '<' + lo):
continue continue
if hi and version_compare(arch, '>=' + hi): if hi and version_compare(arch, '>=' + hi):
if not saturate:
continue
arch = saturate arch = saturate
if arch not in filtered_cuda_arch_list: if arch not in filtered_cuda_arch_list:
filtered_cuda_arch_list.append(arch) filtered_cuda_arch_list.append(arch)