Virtualization
/
meson
mirror of https://gitlab.com/qemu-project/meson.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

compilers: Do not dump File content in log for compiler checks. 

When doing a compiler check with a File object, there is no need to dump
the file into logs, we can just print the path. The file could
potentially be big.
This commit is contained in:
Xavier Claessens 2023-11-06 08:00:43 -05:00 committed by Xavier Claessens
parent f41a95ddf2
commit b1358ef61f
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mesonbuild/compilers/compilers.py
View File

@ -789,14 +789,10 @@ class Compiler(HoldableObject, metaclass=abc.ABCMeta):
ofile.write(code) ofile.write(code)
# ccache would result in a cache miss # ccache would result in a cache miss
no_ccache = True no_ccache = True
contents = code code_debug = f'Code:\n{code}'
else: else:
srcname = code.fname srcname = code.fname
if not is_object(code.fname): code_debug = f'Source file: {srcname}'
with open(code.fname, encoding='utf-8') as f:
contents = f.read()
else:
contents = '<binary>'
# Construct the compiler command-line # Construct the compiler command-line
commands = self.compiler_args() commands = self.compiler_args()
@ -817,7 +813,7 @@ class Compiler(HoldableObject, metaclass=abc.ABCMeta):
command_list = self.get_exelist(ccache=not no_ccache) + commands.to_native() command_list = self.get_exelist(ccache=not no_ccache) + commands.to_native()
mlog.debug('Running compile:') mlog.debug('Running compile:')
mlog.debug('Working directory: ', tmpdirname) mlog.debug('Working directory: ', tmpdirname)
mlog.debug('Code:\n', contents) mlog.debug(code_debug)
os_env = os.environ.copy() os_env = os.environ.copy()
os_env['LC_ALL'] = 'C' os_env['LC_ALL'] = 'C'
if no_ccache: if no_ccache: