Commit Graph

12 Commits

Author SHA1 Message Date
Eli Schwartz 6a0fabc647
mass rewrite of string formatting to use f-strings everywhere
performed by running "pyupgrade --py36-plus" and committing the results
2021-03-04 17:16:11 -05:00
Kyle Stone c89dca8c70 Add ability to specify project branch to install 2020-01-28 19:00:39 -05:00
Kyle Stone f9a31a25db Put subprojects into folder specified by upstream wrap. 2020-01-28 19:00:39 -05:00
Kyle Stone bec46cc141 Fix expected/obtained hashes 2020-01-28 19:00:39 -05:00
Jussi Pakkanen 7375eaa263 Always disable interpolation for ini parsers. 2020-01-27 22:22:12 +02:00
Michael Brockus c0a9bca627 Update Python2 syntax to Python3 syntax in ghwt.py 2019-12-06 14:43:21 +02:00
Andrei Antonov 8f7781f1d6 using urlopen() with explicit timeout 2018-08-27 00:55:45 +03:00
Aleksey Filippov fe215bb826 Use os.path.dirname() instead of os.path.split(...)[0] 2018-03-12 23:03:10 +02:00
Luke Shumaker 3f446a79ec ghwt: Add a comment at the top briefly explaining what it is 2017-09-20 14:02:57 -04:00
Dylan Baker a8173630ea Don't use len() to test emptiness vs not emptiness
Meson has a common pattern of using 'if len(foo) == 0:' or
'if len(foo) != 0:', however, this is a common anti-pattern in python.
Instead tests for emptiness/non-emptiness should be done with a simple
'if foo:' or 'if not foo:'

Consider the following:
>>> import timeit
>>> timeit.timeit('if len([]) == 0: pass')
0.10730923599840025
>>> timeit.timeit('if not []: pass')
0.030033907998586074
>>> timeit.timeit('if len(['a', 'b', 'c', 'd']) == 0: pass')
0.1154778649979562
>>> timeit.timeit("if not ['a', 'b', 'c', 'd']: pass")
0.08259823200205574
>>> timeit.timeit('if len("") == 0: pass')
0.089759664999292
>>> timeit.timeit('if not "": pass')
0.02340641999762738
>>> timeit.timeit('if len("foo") == 0: pass')
0.08848102600313723
>>> timeit.timeit('if not "foo": pass')
0.04032287199879647

And for the one additional case of 'if len(foo.strip()) == 0', which can
be replaced with 'if not foo.isspace()'
>>> timeit.timeit('if len("   ".strip()) == 0: pass')
0.15294511600222904
>>> timeit.timeit('if "   ".isspace(): pass')
0.09413968399894657
>>> timeit.timeit('if len("   abc".strip()) == 0: pass')
0.2023209120015963
>>> timeit.timeit('if "   abc".isspace(): pass')
0.09571301700270851

In other words, it's always a win to not use len(), when you don't
actually want to check the length.
2017-05-02 21:57:26 +03:00
Elliott Sales de Andrade 859c5e28df Use context manager in scripts. 2016-08-30 04:17:47 -04:00
Jussi Pakkanen eb6548a816 Created an emergency wraptool that downloads directly from Github. 2016-05-05 23:18:05 +03:00