Commit Graph

8 Commits

Author SHA1 Message Date
Jon Turney b387ab1ee1 Fix flake8 issues (#3834)
* Fix flake8 whitespace reports

$ flake8 | grep -E '(E203|E221|E226|E303|W291|W293)'
./mesonbuild/coredata.py:337:5: E303 too many blank lines (2)

* Fix flake8 'variable assigned value but unused' reports

$ flake8 | grep -E F841
./mesonbuild/modules/gnome.py:922:9: F841 local variable 'target_name' is assigned to but never used

* Fix flake8 'imported but unused' reports

$ flake8 | grep F401
./mesonbuild/compilers/__init__.py:128:1: F401 '.c.ArmclangCCompiler' imported but unused
./mesonbuild/compilers/__init__.py:138:1: F401 '.cpp.ArmclangCPPCompiler' imported but unused
./mesonbuild/modules/__init__.py:4:1: F401 '..mlog' imported but unused

PR #3717 imports ARMCLANG compilers in __init__, but does not add them to
__all__, so they are not re-exported by the compilers package like
everything else.

* More details about flake8 in Contributing.md

Mention that Sider runs flake8
Suggest seting flake8 as a pre-commit hook
2018-07-05 18:08:04 +00:00
Nirbheek Chauhan d6a9b4cc79 Contributing.md: Document procedure for new features [skip ci] 2018-07-02 19:52:53 +05:30
Jussi Pakkanen 76184bb6b8 Document merge workflow for contributors and maintainers. [skip ci] 2018-07-01 01:11:40 +03:00
Jussi Pakkanen 150351cfdd Document the new and improved review guidelines. [skip ci] 2018-03-22 01:05:25 +02:00
Aleksey Filippov 79865474c7 Add references to CI and recommendation to disable them for doc only changes [skip ci] 2018-02-20 21:21:18 +05:30
Edward Betts bdfcecd2c6 Correct spelling mistakes. 2018-01-19 15:53:00 +02:00
Jussi Pakkanen 7fc46a3d06 Explain test setup a bit more. 2017-12-26 13:35:20 +02:00
Jussi Pakkanen b437977a60 Created documentation page for code contributions. 2017-12-20 21:05:42 +02:00