Virtualization/openbios
1
0
Fork 0
mirror of https://gitlab.com/qemu-project/openbios.git synced 2024-02-13 08:34:06 +08:00
Code Issues Projects Releases Wiki Activity

CIF: Fix trace output for claim and release

Browse Source 
A misplaced digit 8 made it look as if some signedness issue was present
somewhere between libopenbios/client.c:of_client_interface() and
arch/ppc/qemu/methods.c:ciface_claim(). This is not the case;
despite unsigned long -> ucell -> cell -> ucell conversions,
PUSH'ing 0x81234567 and POP'ing works as expected.

Fix the format string to avoid such confusion.
Add zero-padding while at it.

Signed-off-by: Andreas Färber <andreas.faerber@web.de>


git-svn-id: svn://coreboot.org/openbios/trunk/openbios-devel@921 f158a5a8-5612-0410-a976-696ce0be7e32
This commit is contained in:
Andreas Färber
2010-10-25 19:26:40 +00:00
committed by Andreas Färber
parent e31f031549
commit 28516584d1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libopenbios/client.c
View File

@@ -132,10 +132,10 @@ static void dump_service(prom_args_t *pb)
pb->args[0], pb->args[1], pb->args[2]); pb->args[0], pb->args[1], pb->args[2]);
#endif #endif
} else if (strcmp(pb->service, "claim") == 0) { } else if (strcmp(pb->service, "claim") == 0) {
printk("claim(0x8%lx, %ld, %ld) = ", printk("claim(0x%08lx, %ld, %ld) = ",
pb->args[0], pb->args[1], pb->args[2]); pb->args[0], pb->args[1], pb->args[2]);
} else if (strcmp(pb->service, "release") == 0) { } else if (strcmp(pb->service, "release") == 0) {
printk("release(0x8%lx, %ld)\n", printk("release(0x%08lx, %ld)\n",
pb->args[0], pb->args[1]); pb->args[0], pb->args[1]);
} else if (strcmp(pb->service, "boot") == 0) { } else if (strcmp(pb->service, "boot") == 0) {
printk("boot \"%s\"\n", (char*)pb->args[0]); printk("boot \"%s\"\n", (char*)pb->args[0]);