From 43221313e3b5ef74b1e4e41338ef7926f5f6bc1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Sat, 9 Oct 2010 10:16:33 +0000 Subject: [PATCH] Fix getprop return value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit According to IEEE 1275, "Size is either the actual size of the property, or –1 if name does not exist." The property might be larger than the client's buffer, so don't dup the min used for writing into the buffer but the original proplen value. Insert a comment to show what's going on. Signed-off-by: Andreas Färber Signed-off-by: Blue Swirl git-svn-id: svn://coreboot.org/openbios/trunk/openbios-devel@894 f158a5a8-5612-0410-a976-696ce0be7e32 --- forth/system/ciface.fs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/forth/system/ciface.fs b/forth/system/ciface.fs index d7b5c25..ff87608 100644 --- a/forth/system/ciface.fs +++ b/forth/system/ciface.fs @@ -97,8 +97,9 @@ external over cstrlen swap ?phandle get-package-property if 2drop -1 exit then ( buflen buf prop proplen ) - >r swap rot r> min - dup >r move r> + >r swap rot r> + ( prop buf buflen proplen ) + dup >r min move r> ; \ 1 OK, 0 no more prop, -1 prev invalid