From 587a78d75b0e3192691cf0ca9e01ac59a7102e41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Wed, 29 Sep 2010 16:27:42 +0000 Subject: [PATCH] When DEBUG_CIF is defined, a serial message of the form "method(...) = " is emitted by dump_service(). After successful execution the return value and a linebreak are emitted by dump_return(). If however the method fails, nothing is emitted, so that subsequent method calls end up in place of the return value. Observed for getproplen with AIX. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Emit an error indication and a linebreak when DEBUG_CIF is defined. Signed-off-by: Andreas Färber Signed-off-by: Mark Cave-Ayland git-svn-id: svn://coreboot.org/openbios/trunk/openbios-devel@868 f158a5a8-5612-0410-a976-696ce0be7e32 --- libopenbios/client.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libopenbios/client.c b/libopenbios/client.c index 9cea0e7..4c43a99 100644 --- a/libopenbios/client.c +++ b/libopenbios/client.c @@ -306,6 +306,10 @@ of_client_interface( int *params ) if( val == -1 ) printk("Unimplemented service %s ([%ld] -- [%ld])\n", pb->service, pb->nargs, pb->nret ); +#ifdef DEBUG_CIF + else + printk("ERROR!\n"); +#endif return -1; }